-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.3 #694
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
PHP 8.3 was released. What is remaining? The main issue I notice is with the deprecated Could it be solved by doing something like this? $mode = PHP_VERSION_ID >= 80300 ? MT_RAND_MT19937 : MT_RAND_PHP;
mt_srand((int) $seed, $mode); |
Fixed with #844. |
This bug fix is arguably a BC break, it means Faker's output between differs when switching PHP version when using the same seed. If we're happy changing the seeding in a patch release why not just use |
In all likelihood, PHP 8.3 will be released on November 23, 2023, and it would be great if we could support PHP 8.3 soon after the official release.
MT_RAND_PHP
constant on PHP 8.3 #844MT_RAND_PHP
constant deprecated on PHP 8.3MT_RAND_PHP
constant on PHP 8.3 #844The text was updated successfully, but these errors were encountered: