"Failed" mission states still display as succeeded

[Regalis11]

Discussed in #15028

^{Originally posted by ubertpendragon November 2, 2024}

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

When setting the state of missions to "Failed" using MissionStateAction, the failure text is properly displayed, but the game still shows a positive check mark on the mission

Mission type: abandonedoutpost
<MissionStateAction missionidentifier="hostagesituation" operation="Set" value="5" />

Barotrauma/Barotrauma/BarotraumaClient/ClientSource/Events/Missions/AbandonedOutpostMission.cs

Lines 8 to 25 in 7d5b7a3

	public override int State
	{
	get { return base.State; }
	set
	{
	if (state != value)
	{
	base.State = value;
	if (state == HostagesKilledState && !hostagesKilledMessage.IsNullOrEmpty())
	{
	CreateMessageBox(string.Empty, hostagesKilledMessage);
	}
	}
	}
	}
	public override bool DisplayAsCompleted => State > 0 && requireRescue.None();
	public override bool DisplayAsFailed => State == HostagesKilledState;

Failure states usually don't really work across the board and are hard to find in the code as well

Reproduction steps

1. Start a Dynamic Europa campaign https://steamcommunity.com/sharedfiles/filedetails/?id=2532991202
2. setreputation coalition 50
3. triggerevent missionevent_hostagesituation
4. Go to the station with the mission
5. Use this event:

    <ScriptedEvent identifier="MISSIONSTATEACTIONTEST">
      <MissionStateAction missionidentifier="hostagesituation" operation="Set" value="5" />
    </ScriptedEvent>

Bug prevalence

Happens every time I play

Single player or multiplayer?

Single player

-

No response

Version

v1.6.19.1 (Unto the Breach Update Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Regalis11]

Fixed in https://github.com/FakeFishGames/Barotrauma-development/commit/fea70ba9eab4736a75bd6ee7b6d798d088a5215a