Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17.1 plan #59

Closed
35 tasks done
Madis0 opened this issue May 26, 2021 · 30 comments
Closed
35 tasks done

1.17.1 plan #59

Madis0 opened this issue May 26, 2021 · 30 comments
Labels
meta Improvements or additions to CF listing, manifest, etc.

Comments

@Madis0
Copy link
Member

Madis0 commented May 26, 2021

1.17 is released. This is the approximate to-do list for a stable version of the pack:

  • 1.17 Fabric CF: actual Fabric modpack #35, no Jumploader
  • Several of the mods should work
  • Canvas as a temporary Sodium replacement
  • Some alternative zoom mod
  • Options.txt Options.txt #30
  • Your Options Shall Be Respected (YOSBR) #25
  • Packwiz for MultiMC Packwiz #28
  • Enable LDL entities again
  • Revert the FOV change + wiki
  • Readjust Canvas and Smooth lighting
  • Majority of the mods or equivalents updated
  • Sodium update in CF (0.2?)
  • Iris IrisShaders #12
  • Update shader wiki
  • Update controls wiki
  • Explain Packwiz #82
  • Update the mod list and this time add authors as well
  • 1.17.1 released by Mojang
  • 1.17.1 available in CF Launcher
  • FerriteCore
  • Maybe Dependency overrides #76
  • Semver (x.x.x-alpha.x)
  • Enable Cull Leaves by default
  • Update Hydrogen
  • 2.0.0b4 parity (Iris again)
  • Re-evaluate Custom Fog (works under lava? works at all with SodExt? server-side stuff?)
  • Changelog Change #102
  • Test Indium performance
  • Review packwiz py script, make sure all mods are removed before adding from CF
  • Add more Indium-compatible mods
  • Review, which config libraries are actually needed
  • 1.9.1 parity (where feasible)
  • CF bugfix (smooth upgrade from 1.17 -> 1.17.1)
  • Sodium bugfix update (and Iris to go along with it)
  • AdvancementInfo and Better Mount HUD (will be added for release)
@Madis0 Madis0 added the meta Improvements or additions to CF listing, manifest, etc. label May 26, 2021
@Madis0 Madis0 pinned this issue May 27, 2021
@Nadeem-05
Copy link

sodium has a 1.17 dev branch which works fine

@Madis0
Copy link
Member Author

Madis0 commented Jun 9, 2021

@technicaldiff That's great, but I cannot use it in CF unless they decide to publish it.

@Nadeem-05
Copy link

@technicaldiff That's great, but I cannot use it in CF unless they decide to publish it.

CaffeineMC/sodium#674
according to jellysquid it should hopefully be in a week

@ttmx
Copy link

ttmx commented Jun 9, 2021

@technicaldiff Which commit are you using?
Thx

@Nadeem-05
Copy link

Nadeem-05 commented Jun 9, 2021

@ttmx https://github.com/Kroppeb/sodium-fabric/actions/runs/919555548
this one

A contributors fork

@Rajbir98

This comment has been minimized.

@Madis0

This comment has been minimized.

@TheMadHau5
Copy link
Contributor

Why was OK Zoomer replaced with WI Zoom?

@Madis0
Copy link
Member Author

Madis0 commented Jun 11, 2021

@TheMadHau5

  1. It doesn't exist for 1.17 stable
  2. It has future plans about "letting servers disable some parts of the mod". It is a bit confusing for now - will see if and how they will do it. But if it does happen, I will replace it for good because I don't like the idea of giving servers more control than actually needed.

@triphora
Copy link
Contributor

triphora commented Jun 11, 2021

That's great, but I cannot use it in CF unless they decide to publish it.

@Madis0 In overrides, you could include a compiled version of Kroppeb's fork of Sodium here. The license permits redistribution in this regard, so long as a copy of the license is included, and so long as there is a link back to the GH repo somewhere that's somewhat noticeable. (I'm not even sure if the latter part is necessary, but I would do so just to be safe anyway.)

@Madis0
Copy link
Member Author

Madis0 commented Jun 11, 2021

That's great, but I cannot use it in CF unless they decide to publish it.

@Madis0 In overrides, you could include a compiled version of Kroppeb's fork of Sodium here. The license permits redistribution in this regard, so long as a copy of the license is included, and so long as there is a link back to the GH repo somewhere that's somewhat noticeable. (I'm not even sure if the latter part is necessary, but I would do so just to be safe anyway.)

I don't know, few months back (I think it was for 1.16.3) I tried uploading a version with a custom-compiled Sodium and it got rejected.

@Nadeem-05
Copy link

That's great, but I cannot use it in CF unless they decide to publish it.

@Madis0 In overrides, you could include a compiled version of Kroppeb's fork of Sodium here. The license permits redistribution in this regard, so long as a copy of the license is included, and so long as there is a link back to the GH repo somewhere that's somewhat noticeable. (I'm not even sure if the latter part is necessary, but I would do so just to be safe anyway.)

I don't know, few months back (I think it was for 1.16.3) I tried uploading a version with a custom-compiled Sodium and it got rejected.

secondly kroppebs fork has actually a pr open in jelly squids sodium and is pending merge and i tried his forks sodium with the pack and its much much better than canvas

@Madis0
Copy link
Member Author

Madis0 commented Jun 12, 2021

https://support.overwolf.com/en/support/solutions/articles/9000197913-non-curseforge-mods

It can take several days for a review to occur, but once it has you will be notified with either a message declining the addition or approving it along with any information as to why or why not.

If a specific version of a CurseForge-hosted mod is not on the site, this means the author has chosen not to upload it for some reason. These versions are not allowed to be included in modpacks.

@triphora
Copy link
Contributor

typical curseforge, thinking that everything has to go through them...

@Madis0
Copy link
Member Author

Madis0 commented Jun 12, 2021

I think it actually makes sense:

  • JARs could easily include malware, additional checks for non-CF versions waste CF-s time to review
  • Non-CF JARs don't increase the developers' mods' download count, which doesn't help with getting rewards or increasing popularity of the mods
  • Developers could get annoyed when modpacks publish development versions (and they get the crash reports/issues regarding those) or maybe even stolen/modded versions of some ARR mods

@Nadeem-05
Copy link

makes sense...how about publishing it in github and then when jelly squid releses pushing it to CF

@Madis0
Copy link
Member Author

Madis0 commented Jun 12, 2021

makes sense...how about publishing it in github and then when jelly squid releses pushing it to CF

That fragments the download locations, making life more complicated for me, the modders and the users (see the points I posted above), so unfortunately that's a no. But as always, I do encourage my users to use more mods than there are in the pack.

@Rajbir98

This comment has been minimized.

@Madis0 Madis0 added this to the MC 1.17/FO 2.0 milestone Jun 18, 2021
@Madis0 Madis0 changed the title 1.17 plan 1.17.1 plan Jul 8, 2021
@piosrunix
Copy link

any idea when you guys will release this update?

@Madis0
Copy link
Member Author

Madis0 commented Jul 12, 2021

any idea when you guys will release this update?

I'll release a stable version when Sodium is stable enough and parity with 1.16.5 version has been reached.

@TinyMandalorian
Copy link

TinyMandalorian commented Jul 18, 2021

Sodium Extras has released for 1.17.1 same with sodium 1.17.1
https://modrinth.com/mod/sodium

https://www.curseforge.com/minecraft/mc-mods/sodium-extra

ANOTHER EDIT
theres a new mod called starlight its better then phosphorus apparnetly.
https://github.com/Tuinity/Starlight

@Madis0
Copy link
Member Author

Madis0 commented Jul 18, 2021

@Gavins38 Thanks. Regarding Starlight: #21

@TinyMandalorian
Copy link

@Gavins38 Thanks. Regarding Starlight: #21

Ty for updating but uh i think theres some serious visual bugs
#96.

@Rajbir98
Copy link

Sodium has messed up many things this time causing visual bugs and performance drop

@triphora
Copy link
Contributor

@Rajbir98 You're probably either using old AMD or Intel drivers on Windows, in which case the bugs are known but extremely hard for the Sodium devs to fix

@Rajbir98
Copy link

its true i am on legacy driver

@Rajbir98
Copy link

sodium devs is still working hard towards legacy driver users https://github.com/CaffeineMC/sodium-fabric/actions/runs/1062321084 heres the latest build action

@Rajbir98

This comment has been minimized.

@lebestnoob
Copy link

Iris now has support for 1.17.1. The latest version is available on the projects GitHub release page. Will it be included?
Download

@Madis0 Madis0 closed this as completed Sep 6, 2021
@Madis0
Copy link
Member Author

Madis0 commented Sep 6, 2021

2.1.0 has been released!

@Madis0 Madis0 unpinned this issue Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Improvements or additions to CF listing, manifest, etc.
Projects
None yet
Development

No branches or pull requests

9 participants