Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wand of Symmetry causes stack overflow when mining affected blocks #1048

Closed
WillRDorval opened this issue Aug 10, 2023 · 0 comments
Closed
Labels
type: bug Issue where something isn't working

Comments

@WillRDorval
Copy link

Describe the Bug

When mining blocks affected by the wand of symmetry the server side of the game crashes from a stack overflow seemingly caused by the infinite loop:
at net.fabricmc.fabric.api.event.player.PlayerBlockBreakEvents.lambda$static$0(PlayerBlockBreakEvents.java:44) ~[fabric-events-interaction-v0-0.4+562bff6e90-345addfd7cf1e1a2.jar:?]
at com.simibubi.create.content.equipment.symmetryWand.SymmetryWandItem.handlePreEvent(SymmetryWandItem.java:334) ~[create-fabric-0.5.1-c-local+mc1.19.2.jar:?]
at com.simibubi.create.content.equipment.symmetryWand.SymmetryWandItem.remove(SymmetryWandItem.java:308) ~[create-fabric-0.5.1-c-local+mc1.19.2.jar:?]
at com.simibubi.create.content.equipment.symmetryWand.SymmetryHandler.onBlockDestroyed(SymmetryHandler.java:86) ~[create-fabric-0.5.1-c-local+mc1.19.2.jar:?]
at net.fabricmc.fabric.api.event.player.PlayerBlockBreakEvents.lambda$static$0(PlayerBlockBreakEvents.java:44) ~[fabric-events-interaction-v0-0.4+562bff6e90-345addfd7cf1e1a2.jar:?]

which repeats infinitely, bug was repeatable on the most recent commit to the mc1.19/fabric.dev branch using the gradle run client task

Reproduction Steps

  1. Place a mirror using the Wand of Symmetry
  2. Place a block on one side
  3. Break that block

...

Expected Result

Both blocks should break

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/FAtnr4CD

Operating System

Windows 11 and also Linux server

Mod Version

0.5.1d

Minecraft Version

1.19.2

Other Mods

A bunch of other mods were running in a modpack but the bug was reproduced in the development environment without any additional mods being added on a fresh clone of this repo

Additional Context

The bug initally happened on a slightly modified version of create 0.5.1b but was recreated on 0.5.1d in testing to see if it was an issue with the modifiactions or create itself so it ahs been marked 0.5.1d

@WillRDorval WillRDorval added the type: bug Issue where something isn't working label Aug 10, 2023
@github-actions github-actions bot added the 1.19 label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant