Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Issues #179

Open
Bogie21 opened this issue Sep 22, 2015 · 2 comments
Open

Volume Issues #179

Bogie21 opened this issue Sep 22, 2015 · 2 comments

Comments

@Bogie21
Copy link

Bogie21 commented Sep 22, 2015

When you mute, them un-mute, volume goes to 80%. Functionality speaking, it would be better (in my opinion) for the volume to revert back to previous user setting.

As well, if you navigate away from the room (which can happen if you're new to the site and haven't set the preference yet) the volume mute/unmute toggle button loses its color (Image turns white on very light gray vs black on white).
image

@Bogie21
Copy link
Author

Bogie21 commented Sep 28, 2015

To go along with this. I have the site muted, yet every time a new song comes on, it plays the first second or so of the song. .

@martindale
Copy link
Member

Great feedback. This is due to the current mode of destroying the player and then re-initializing it (to deal with API inconsistencies between YouTube and MP3s), but should go away completely once sampotts/plyr#8 is complete. We'll replace the whole player at that point, which should close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants