Skip to content
This repository has been archived by the owner on Jul 25, 2020. It is now read-only.

GameRuleRegistry#register Shouldn't Take an Identifier #1

Open
Haven-King opened this issue May 20, 2020 · 1 comment
Open

GameRuleRegistry#register Shouldn't Take an Identifier #1

Haven-King opened this issue May 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Haven-King
Copy link
Contributor

Identifiers must follow snake case, while vanilla gamerules use camelcase. This means custom gamerules can't follow vanilla conventions.

Can be worked around by calling GameRulesAccessor#invokeRegister manually, though that's not intuitive, and a merged version would ideally not require it.

@i509VCB
Copy link
Contributor

i509VCB commented May 20, 2020

Hmm, I could just let people pass a string through. And the game does crash if you register a rule with an existing rule key.

@i509VCB i509VCB added the enhancement New feature or request label May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants