-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error during point assignment in JBA 3.1 (same coordinate works with JBA 3.0.3) #1468
Comments
TLDR: siibra-python is too memory hungry. next version of siibra should (hopefully) fix this issue. As it stands, the point assignment will often fail (depending on if other users have used point assignment on other parcellations etc) Please see below the same point assigned (hopefully correctly) and the zip file of the assignment |
Apologies. The performance of siibra-explorer/api is quite lacking when it comes to memory hungry tasks. We are in the process of remedying it in the coming version.
(screenshot removed and full assignment removed)
edit: apologies for the previous comment. I misunderstood the assignment. The screenshot and previous attachment refer to the assignment of julich brain at the moment, this operation cannot be carried out on the viewer, unfortunately. we will endeavor to make it available as soon as possible. (sparse index is not available, so it appears that all volumes are loaded in memory, which causes OOM, and crashes the runner.) In a more powerful machine, the assignment can be done. But worryingly, with different ressult. on 0.4a80: https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/runs/10440230365/job/28909876225#step:5:540
on 1.0a8 and beyond https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/runs/10440230365/job/28909876028#step:5:537
(this matches to the result that @SBludau quoted) ping @AhmetNSimsek probably still worthwhile investigating the discrependency |
This was a bug on version 1.0a08 of siibra-python and it was remedied by 1.0a09. I can provide more context @SBludau. About assignment issues on explorer to 3.1, we have an idea. I am making a fix at the moment.
|
Coordinate 32mm, -28mm, -8mm gives CA3 in JBA 3.0.3, which is correct. After a switch to JBA 3.1 the position seems to be correct as well, so the crosshair is located at the correct position, but the assignment produces an error.
JBA 3.0.3 Output
JBA 3.1 Output
@ Xiao: could you provide an estimation of the timeframe required to address this issue. The assignment is needed for an update to a publication that is currently in its final stages. (However, I want to emphasize that there is no immediate urgency, as the lead author is on vacation for 2 weeks ;-) )
The text was updated successfully, but these errors were encountered: