Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None quest shape #1448

Open
MichaelHillcox opened this issue Jan 6, 2025 · 2 comments
Open

None quest shape #1448

MichaelHillcox opened this issue Jan 6, 2025 · 2 comments
Assignees
Labels
2: Feature New feature or request. FTB Quests state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release.

Comments

@MichaelHillcox
Copy link
Member

Mod

FTB Quests

Description

Add a new builtin shape of “none”, which simply doesn’t render anything. For if a quest only wants to render an image/item and not a background shape.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

@desht
Copy link
Contributor

desht commented Jan 6, 2025

This is mostly easy to do, but there's a complication: how to render locked quests, i.e. ones that can't be started yet due to dependencies. Example:

Image

Quest on the left has a "none" shape, quest on right using default shape. It's much clearer that the right-hand quest is currently locked due to the darkened background.

Note that darkening the item itself isn't easy to do, due to the way vanilla handles lighting of GUI-rendered items, and we don't even know for sure if the icon being rendered is an item, or something else entirely.

Maybe the best option is to render a little padlock icon over quests that can't be started yet, but now we're creeping in scope 😄

@MichaelHillcox
Copy link
Member Author

Yeah, I think something like a little padlock might be ideal for those. It might also be good for the shapes?

@desht desht moved this from Ready to In progress in Mods Backlog Jan 6, 2025
desht added a commit to FTBTeam/FTB-Quests that referenced this issue Jan 7, 2025
Lock icon controllable via both a quest file setting and player preferences
Enabled by default

FTBTeam/FTB-Mods-Issues#1448
@desht desht added the state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Feature New feature or request. FTB Quests state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release.
Projects
Status: In progress
Development

No branches or pull requests

2 participants