[Bug]: FTB Quests Reward Tables items do not save name after exiting Reward Tables interface.

[Miqote-Petter]

Mod

FTB Quests

Mod version

FTB Quests (Neoforge): 2101.1.1

NeoForge / Forge / Fabric version

Neoforge 1.21.1 21.1.90

What issue are you having?

When making a reward table with game stages as a reward, the "title" option resets upon leaving the reward table interface. This results in the stages reward title reverting to "stages: xxx."

Steps to reproduce

1. Open Edit Rewards Tables
2. Add a reward table, name it as you see fit.
3. Add a game stage reward. Fill it out, including title. At this point, it will properly show the title of the Stage reward.
4. Exit the Reward Tables interface.
5. Either: open Rewards Tables and edit again or add as a reward to quest.
6. Reward table items have reverted back to "stages: xxx" instead of a proper title.

[desht]

Confirmed.

[desht]

This is unfortunately going to be a bit more difficult to resolve than I hoped. Technical detail: the rewards embedded in a reward table are the same Java class as the rewards in a quest (class Reward). However, rewards in a reward table don't have a unique quest object ID (because they haven't historically needed them), whereas rewards in a quest do have their own ID.

Now in 1.21, FTB Quests has a new translation system whereby all translatable strings are moved out of the quest files and into a lang/<lang-code>.snbt file. Entries in this file are keyed by the... quest object ID. And since reward table rewards have no ID (or more precisely a fake ID of 0), their title isn't working.

The fix for this will be to ensure these rewards all get their own unique ID's, which is possible to do, but a bigger change than I hoped, and one which will need a fair bit of testing. So won't be in the next FTB Quests release, but the following one.

[Miqote-Petter]

Thank you very much for a speedy response!! I am glad to hear that it will be fixed in a future release, and can understand why it isn’t a quick fix based off your explanation. Thank you for your time and work on this mod, and I hope your holidays went great!

…

On Thu, Jan 2, 2025 at 06:38 desht ***@***.***> wrote: This is unfortunately going to be a bit more difficult to resolve than I hoped. Technical detail: the rewards embedded in a reward table are the same Java class as the rewards in a quest (class Reward). *However*, rewards in a reward table don't have a unique quest object ID (because they haven't historically needed them), whereas rewards in a quest do have their own ID. Now in 1.21, FTB Quests has a new translation system whereby all translatable strings are moved out of the quest files and into a lang/<lang-code>.snbt file. Entries in this file are keyed by the... quest object ID. And since reward table rewards have no ID, their title isn't working. The fix for this will be to ensure these rewards all have their own ID's, which is possible to do, but a bigger changed than I hoped. So won't be in the next FTB Quests release, but the following one. — Reply to this email directly, view it on GitHub <#1442 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYMXDB74TAHWDPYMUA4F4VD2IVFNZAVCNFSM6AAAAABUO5KVX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRXHA3TENZWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>