Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source popup in the Answer section doesn't get activated on mobile #8

Open
HamedMP opened this issue Apr 5, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@HamedMP
Copy link
Collaborator

HamedMP commented Apr 5, 2024

The source popups in the answer don't get activated when clicking them.

@HamedMP HamedMP added the bug Something isn't working label Apr 5, 2024
@HamedMP
Copy link
Collaborator Author

HamedMP commented Apr 5, 2024

By Emil: shadcn-ui/ui#86

Tl;dr:

They are three components:
Tooltip
Hover Card
Popover
Tooltip and Hover Card are only meant to be used on desktop. Popover is meant to be used on desktop and mobile.

This is a radix-ui/primitives#955 (comment). I think it wouldn't make sense to change it here at Shadcn-UI 🤔 so I reckon this issue can be closed.

If you need a hybrid solution, which mounts a popover on mobile and a tooltip by default, have a look at shadcn-ui/ui#2402 (comment) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant