Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ChrisClient.from_chrs #1

Open
jennydaman opened this issue May 3, 2023 · 1 comment
Open

Feature: ChrisClient.from_chrs #1

jennydaman opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jennydaman
Copy link
Contributor

Feature request to add a constructor ChrisClient.from_chrs(url, username, config="~/.config/chrs/login.toml") which parses the chrs login config file to obtain a token, then calls ChrisClient.from_token
@jennydaman jennydaman added enhancement New feature or request good first issue Good for newcomers labels May 3, 2023
@jennydaman
Copy link
Contributor Author

jennydaman commented Jul 23, 2024 •
edited
Loading

This was implemented in aiochris v0.3.0 and working with chrs v0.2.4 but broken by chrs v0.3.0.

The function ChrisClient.from_chrs raises NotImplementedError in aiochris v0.5.0 and above. Please comment below if you need this feature and want me to work on it.

@jennydaman jennydaman mentioned this issue Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jennydaman