Search results bug

[jennydaman]

Searching for a plugin which does not exist shows "-1 plugins found"

https://next.chrisstore.co/plugins?q=doesnotexist

[patrikhv]

Hi, can you assign this issue to me? I would like to fix this bug.
Can I get any additional information and tips?

[zrthxn]

@patrikhv
The Plugins list page finds the query param q from the URL to use as search query.

ChRIS_store_ui/src/components/Plugins/Plugins.jsx

Lines 134 to 135 in 8e8d2d7

	const params = new URLSearchParams(window.location.search)
	const query = params.get('q');

It then sends the formatted query object to the store API
If the there are no matches, the API responds with a response that has a shape like so

{
  // ... other keys
  "totalCount": -1
}

This is fine for the API but we don't want to show that "-1" directly. Instead there should be a check that changes the rendered output to something like "No Results" or "0 results"

[mairin]

Is this one fixed? Can I close it?

[somya51p]

@jennydaman Is this issue still open to work on?? if so please assign it to me.

[somya51p]

@mairin @jennydaman just found a minor bug in the pagination part while searching plugins

Kindly assign me this issue so that I can fix it and create a PR