Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up tests for build and basic functionality #244

Open
zrthxn opened this issue Oct 17, 2021 · 5 comments
Open

Set up tests for build and basic functionality #244

zrthxn opened this issue Oct 17, 2021 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zrthxn
Copy link
Member

zrthxn commented Oct 17, 2021

Tests can be set up with Github Actions to test the following

  • Is the yarn build successful?
  • Is the linting passing without errors?
  • Is the Docker build successful?
  • (other ideas...)
@zrthxn zrthxn added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 17, 2021
@EUGINELETHAL
Copy link
Contributor

@zrthxn let me work on this

@somya51p
Copy link
Contributor

somya51p commented Apr 5, 2022

@jennydaman @zrthxn I wish to work on this issue. Please assign it to me.

@EUGINELETHAL
Copy link
Contributor

EUGINELETHAL commented Apr 5, 2022 via email

@jennydaman
Copy link
Collaborator

Hey @somya51p, @Mfonn is doing some work on testing and we realized that many of the tests are broken (outdated). We're working on fixing them.

For context, tests were disabled (from running automatically using husky) while we were doing a major rewrite to use Patternfly4. It would be great if we could get those tests back up to speed and running automatically.

@somya51p
Copy link
Contributor

somya51p commented Apr 7, 2022

@jennydaman ok, I will try to add GitHub actions and will ignore the test results for now if you think that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants