Email address in homepage Developer Signup #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrthxn
requested changes
Oct 11, 2021
src/components/Welcome/components/WelcomeDevelopers/WelcomeDevelopers.jsx
Outdated
Show resolved
Hide resolved
|
@ppk-1996 Is this ready for merge? |
Yes, it is ready for merge. |
zrthxn
requested changes
Oct 19, 2021
src/components/Welcome/components/WelcomeDevelopers/WelcomeDevelopers.jsx
Outdated
Show resolved
Hide resolved
zrthxn
reviewed
Oct 19, 2021
zrthxn
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
Added email address text field before the sign up button. This is my first ever pull request so please feel free to ask for more work. I'll contribute to ChRIS_store_ui and ChRIS_ui for any frontend related task.