Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Categories" object and allow all categories to be fetched #42

Open
zrthxn opened this issue Apr 13, 2021 · 4 comments
Open

Add "Categories" object and allow all categories to be fetched #42

zrthxn opened this issue Apr 13, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@zrthxn
Copy link
Member

zrthxn commented Apr 13, 2021

The Category of a plugin is currently only a string and anything can be put in its place.
This is a feature request to add a Categories object which can have certain predefined values and the ability to create more, such that a plugin can be assigned that category.

Also the API should be able to serve a list of categories when it needs to.

@zrthxn
Copy link
Member Author

zrthxn commented Apr 13, 2021

If this seems something that an applicant can do then I'd like to help on this.

@jennydaman jennydaman added the enhancement New feature or request label Apr 13, 2021
@jennydaman
Copy link
Collaborator

To add this feature I think one would need a good understanding of the codebase and database design. Feel free to give it your shot. If it becomes apparent that the task is too large for now, it is ok to choose a different task instead.

@mairin
Copy link
Collaborator

mairin commented Jun 1, 2021

One consideration here that came up in our planning meeting this morning is that having metadata like categories as part of the JSON in the plugin itself is that it would enable categorization of the plugins elsewhere - like in the ChRIS core UI itself.

We could maybe instead create a standard list of categories that we promote on the ChRIS Store as suggestions and allow the ChRIS store admin to change / edit / update. And perhaps when you upload a JSON plugin def file, if it has a category field that lists categories that arent part of that list, it flags it maybe?

Multiple categories should be allowed per plugin though. The idea mentioned today way "One category per plugin, specified in JSON - should expand. Should be backwards-compatible where CATEGORIES can be a comma-separated list of keywords."

@mairin
Copy link
Collaborator

mairin commented Jan 24, 2022

See #43 for more discussion / information on this idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants