Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to 'containerize.sh' features after Buildah version updated #19

Open
aperloff opened this issue Jun 26, 2021 · 0 comments
Open

Comments

@aperloff
Copy link

aperloff commented Jun 26, 2021

This issue is related to files which will be added with #18.

The version of Buildah on cmslpcheavy-sl7 right now is 1.11.6, but the latest version is 1.21.0. The later versions have a feature that allow the use of ARG commands within a COPY commands parameters (i.e. chown) inside of a Dockerfile. This would allow us to remove the hard coded cmsusr username in https://github.com/FNALLPC/lpc-scripts/pull/18/files#diff-64e49c956c3cc82ad01ae4cc0497f5ee63343fa4b61c8c7733199205ca5bd187R47. That line would change to be something like:

ARG USERNAME_BUILD=cmsusr
ARG USERNAME=cmsusr
COPY --from=builder --chown=${USERNAME}:${USERNAME} /home/${USERNAME_BUILD}/${CMSSW_VERSION} /home/${USERNAME}/${CMSSW_VERSION}
aperloff pushed a commit to aperloff/lpc-scripts that referenced this issue Jun 28, 2021
aperloff pushed a commit to aperloff/lpc-scripts that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant