Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faces in xarray accessor exclude cyclic elements #136

Open
koldunovn opened this issue May 3, 2021 · 2 comments
Open

faces in xarray accessor exclude cyclic elements #136

koldunovn opened this issue May 3, 2021 · 2 comments
Assignees

Comments

@koldunovn
Copy link
Member

Currently faces in xarray accessor - exclude cyclic elements. It's good for plotting, but not so nice for data analysis. We have to discuss what to keep. I would rather go for excluding cyclic elements during plotting itself, not to hide this info from the user.

@koldunovn
Copy link
Member Author

Here is an example of a function that use all nodes:

def tonodes_jit(component, n2d, voltri, elem, e2d, lump2):

Anyway by cutting down the elements we don't provide the complete data to the user. I think whether or not cyclic points should be excluded should be decided on (plotting) function level, not at the dataset level.

@suvarchal suvarchal self-assigned this May 3, 2021
suvarchal added a commit that referenced this issue May 4, 2021
@suvarchal
Copy link
Collaborator

it is fixed in #134 , but more work to go in that PR.

@suvarchal suvarchal reopened this Oct 11, 2022
suvarchal added a commit that referenced this issue Oct 11, 2022
…optimization for plotting, also fixes #136 and addresses #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants