Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using OPENMP_REPRODUCIBLE doesn't compile due to missing clause in openmp directives #444

Open
suvarchal opened this issue Mar 25, 2023 · 3 comments
Milestone

Comments

@suvarchal
Copy link
Collaborator

suvarchal commented Mar 25, 2023

cannot compile the model with -DOPENMP_REPRODUCIBLE=ON (must be used together with -DENABLE_OPENMP).

error is

The DO directive to which the ordered section binds does not have the ORDERED clause specified.
!$OMP ORDERED

for multiple files that use openmp directives.

Not sure if this is because of openmp version.

and also note for future:

  • OPENMP_REPRODUCIBLE compile option is currently independent of ENABLE_OPENMP, it should be only relevant when OPENMP is used.
@trackow
Copy link
Contributor

trackow commented Mar 26, 2023

Fully agree! Do you test things with it at the moment? For me, it does not compile with Intel, by the way, when using OPENMP_REPRODUCIBLE=ON

@suvarchal
Copy link
Collaborator Author

suvarchal commented Mar 28, 2023

@trackow totally right! doesn't compile even due to inconsistent directives? @dsidoren

The DO directive to which the ordered section binds does not have the ORDERED clause specified.
!$OMP ORDERED 

means something to you?

I am repurposing this issue for that.

@suvarchal suvarchal changed the title OPENMP_REPRODUCIBLE should only be available when ENABLE_OPENMP is used using OPENMP_REPRODUCIBLE doesn't compile due to missing clause in openmp directives Mar 28, 2023
@JanStreffing
Copy link
Collaborator

Still an issue, or can be closed?

@JanStreffing JanStreffing added this to the FESOM 2.6.1 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants