Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clan] updating a clan will not purge the cache #812

Closed
fcaps opened this issue Dec 10, 2023 · 3 comments · Fixed by #917
Closed

[clan] updating a clan will not purge the cache #812

fcaps opened this issue Dec 10, 2023 · 3 comments · Fixed by #917

Comments

@fcaps
Copy link
Contributor

fcaps commented Dec 10, 2023

there is an ux issue if the clan is getting updated (join/leave/edit) if will not show up directly due a 5min cache in elide.
is there something we can do without making it too complex?

the endpoint i am talking about /data/clan/${id}?include=memberships.player
@Brutus5000
Copy link
Member

In the ClanService you need to inject the CacheManager and when you create/update/delete a clan, you need to get the cache with key Clan.TYPE_NAME and clear it.

@Sheikah45
Copy link
Member

Why not just use @CacheEvict on the method?

@Brutus5000
Copy link
Member

That might work too. Not the expert on caching

Ivan-Shaml added a commit to Ivan-Shaml/faf-java-api-fork that referenced this issue Dec 23, 2024
@Ivan-Shaml
fix(cache): evict clan cache after changes to entity/related entities
77791ff 
 Closes FAForever#812
Ivan-Shaml added a commit to Ivan-Shaml/faf-java-api-fork that referenced this issue Dec 23, 2024
@Ivan-Shaml
fix(cache): evict clan cache after changes to entity/related entities
04c6f7b 
 Closes FAForever#812
@Ivan-Shaml Ivan-Shaml mentioned this issue Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clan] updating a clan will not purge the cache Ivan-Shaml/faf-java-api-fork
3 participants
@Brutus5000 @fcaps @Sheikah45