Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export with duplicated values in Attributes column #291

Open
mikeg-de opened this issue Dec 14, 2020 · 2 comments
Open

Export with duplicated values in Attributes column #291

mikeg-de opened this issue Dec 14, 2020 · 2 comments

Comments

@mikeg-de
Copy link

The Attributes column contains duplicated values which decreases performance:

Colour(s)=Black\|Length=1\|Colour(s)=Black\|Length=5\|Colour(s)=White\|Length=1\|Colour(s)=White\|Length=5\|

Bildschirmfoto 2020-12-14 um 19 34 27

@fmarangi
Copy link
Contributor

Hi @mikeg-de this was already addressed in v2 of the module which we are working on, cmp:

fd46283#diff-4548d58fb4f49f860d6346d97d19ca72e16f9bc3c9b0382b356cdefd0764502aR58

The performance loss is not really a huge deal in this case, but you are right, it is not exported in the best possible way. We are not planning on porting this to v1 but maybe you can open a PR for it.

@mikeg-de
Copy link
Author

Thanks. When will v2 be published as the changelog still list .1.6.4 as the most recent one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants