You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The easiest would be to add additional return values out of select_ring_peaks_by_intensity (and sorted_peak_intensity_mask for the cumsum) but this risks breaking other uses of select_ring_peaks_by_intensity. So we are not actually sure it would be the best solution, what do you think ? Another possibility is to extract common computation in other functions.
Related, we don't need to have plotting since we are only interested in the data. But that is only a minor annoyance since the plot can be disabled by setting doplot to None.
Again, happy to discuss this further with you
The text was updated successfully, but these errors were encountered:
I agree - it is very annoying to recompute this all when changing the cutoff parameter. We also need to save cor_intensity (for example, into the colfile, this is needed for plotting and to check the "B" parameter).
Again for #358
We would need to get additional data out of the
select_ring_peaks_by_intensity
function.Namely, we would need the cumulative sums (defined here:
ImageD11/ImageD11/peakselect.py
Line 89 in d03c18a
ImageD11/ImageD11/peakselect.py
Line 89 in d03c18a
The easiest would be to add additional return values out of
select_ring_peaks_by_intensity
(andsorted_peak_intensity_mask
for the cumsum) but this risks breaking other uses ofselect_ring_peaks_by_intensity
. So we are not actually sure it would be the best solution, what do you think ? Another possibility is to extract common computation in other functions.Related, we don't need to have plotting since we are only interested in the data. But that is only a minor annoyance since the plot can be disabled by setting
doplot
toNone
.Again, happy to discuss this further with you
The text was updated successfully, but these errors were encountered: