Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing space in PR title does not get caught #562

Closed
scarf005 opened this issue Mar 10, 2024 · 4 comments · Fixed by #698
Closed

missing space in PR title does not get caught #562

scarf005 opened this issue Mar 10, 2024 · 4 comments · Fixed by #698
Assignees
Labels
bug Something isn't working

Comments

@scarf005
Copy link
Contributor

scarf005 commented Mar 10, 2024

Describe the bug

image

from cataclysmbnteam/Cataclysm-BN#4329

semantic.yml contents

enabled: true
titleOnly: true
targetUrl: 'https://docs.cataclysmbn.org/en/contribute/changelog_guidelines/'
types:
  - feat
  - fix
  - docs
  - style
  - refactor
  - perf
  - test
  - build
  - ci
  - chore
  - revert

# irrelevant configs skipped   

https://github.com/cataclysmbnteam/Cataclysm-BN/blob/59eb28f4a7404d1ec2f4be1eaa387d4317a8a812/.github/semantic.yml

Sample PR Title(s) (if relevant)

feat(content):Cooking with insect eggs

Sample Commit Message(s) (if relevant)

No response

@scarf005 scarf005 added the bug Something isn't working label Mar 10, 2024
@dhrapson
Copy link

We are hitting this also. Is this app still being supported in terms of code changes?

@Ezard
Copy link
Owner

Ezard commented Sep 24, 2024

Hey @scarf005 @dhrapson,

Apologies for the slow response - life has been busy recently!

This app uses @conventional-commits/parser to check whether a PR title is semantic or not (see https://github.com/Ezard/semantic-prs/blob/master/functions%2Fsrc%2Fis-message-semantic.ts#L30) - might be worth seeing if the maintainers of that package are open to adding this extra check?

If not then I can write my own parsing function for this app 🙂

@scarf005
Copy link
Contributor Author

looks like it's tracked in @conventional-commits/parser conventional-commits/parser#47, but the repo is unmaintained since 2021 - I'm willing to open a PR with custom validator function.

@Ezard
Copy link
Owner

Ezard commented Dec 29, 2024

@dhrapson @scarf005 finally got some time over the holiday period to sort this; it's now been deployed 🙂

(thanks to @scarf005 for providing the fix!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants