-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phin
should be upgraded or removed
#11
Comments
phin
used for?phin
should be upgraded or removed
@KernelDeimos It seems this package is maintained by @mattdesl among others. I also use |
I’ll be honest; I don’t know why jimp (an image manipulation library) needs to depend on my module (font tools for games). It seems like scope bloat. One of the goals of this library is to load a URL resource that might be a buffer or json response, and decode the BMFont file spec into memory in a convenient way, primarily for games and web graphics. So I do not think it makes sense to strip HTTP requests out—it would make the module significantly less useful (it would also be a breaking change). The other goal is for this code to be isomorphic; so it makes no sense to break Node support. And, deprecation does not mean broken—the developer of phin seems to not have the time to support it, but there is not any reported issue with the version this module depends on. I think you would be better off taking up your issue with the upstream package rather than this one. Cheers! |
@mattdesl Is it difficult to update the Either way, I will use |
Best principal of reliable development - do not use third party packages if this is possible, because usually they are not maintained as they should. |
apparently it wasn't actually okay to use phin until yesterday
The package
jimp
depends on this. It processes images. My use-case for it is a fallback image resizer when an optional compiled image resizer is not available.A module I'm using to resize images... depends on an http client.
Is this for browser environments specifically? Is there a convenient way to disable this, or a way I can be entirely sure it will never be used within a nodejs environment?
The text was updated successfully, but these errors were encountered: