Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent logo background should clip out a square #211

Open
yefim opened this issue Aug 28, 2024 · 0 comments · May be fixed by #212
Open

Transparent logo background should clip out a square #211

yefim opened this issue Aug 28, 2024 · 0 comments · May be fixed by #212

Comments

@yefim
Copy link

yefim commented Aug 28, 2024

Currently, when you use a "transparent" or "none" logo background, the QR code renders underneath which is not great! Instead, we should use an SVG clip-path to not render the QR code underneath the logo. Here's a codepen to show what I mean: https://codepen.io/yefim/pen/KKjByvo

Here's the bug in action:

Screenshot 2024-08-28 at 6 52 54 PM

And here is it with a "white" background which looks better but not perfect

Screenshot 2024-08-28 at 6 53 16 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant