Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Expensify Card - Username, last 4 and limit amount are not aligned on the same line #52663

Open
3 of 8 tasks
lanitochka17 opened this issue Nov 16, 2024 · 13 comments
Open
3 of 8 tasks

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #52529

Action Performed:

Precondition:

  • Expensify Card is enabled in the workspace.
  • There is at least one workspace member with virtual card
  1. Launch ND or hybrid app
  2. Go to workspace settings
  3. Go to Expensify Card

Expected Result:

User name, last 4 digits and limit amount will be aligned on the same line

Actual Result:

User name, last 4 digits and limit amount are not aligned on the same line (please refer to screenshot)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
57 44

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 16, 2024
Copy link

melvin-bot bot commented Nov 16, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 16, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:
IMG_7080

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 17, 2024

I think this is the expected #52529 (comment)

@mountiny
Copy link
Contributor

happy to take over as I work on this one

@mountiny mountiny added Daily KSv2 Design and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 18, 2024
Copy link

melvin-bot bot commented Nov 18, 2024

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@mountiny
Copy link
Contributor

I agree this is not a blocker, as we made this change intentionally. However, I can see that the card name is a little bit off, imho. @Expensify/design are you able to check the images cc @nkdengineer

@dannymcclain
Copy link
Contributor

I also agree this is not a blocker, but the alignment is definitely off. From Figma, the Name, Last 4, and Limit should all sit on a common baseline.

CleanShot 2024-11-18 at 09 32 27@2x

@mountiny
Copy link
Contributor

@nkdengineer sorry for the trouble but this is something we did not catch in the PR so I should assign you here, can you please comment?

@nkdengineer
Copy link
Contributor

I'm here

@nkdengineer
Copy link
Contributor

Screenshot 2024-11-18 at 22 51 21

@DylanDylann, @mountiny, @Expensify/design here is the result from my side, it seems they are not on the same line and are about 1-2px different
I will investigate and create PR to fix tomorrow

@shawnborton
Copy link
Contributor

Agree with the comments above. Hopefully it's a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants