-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Expensify Card - Username, last 4 and limit amount are not aligned on the same line #52663
Comments
Triggered auto assignment to @MarioExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I think this is the expected #52529 (comment) |
happy to take over as I work on this one |
Triggered auto assignment to @shawnborton ( |
I agree this is not a blocker, as we made this change intentionally. However, I can see that the card name is a little bit off, imho. @Expensify/design are you able to check the images cc @nkdengineer |
I also agree this is not a blocker, but the alignment is definitely off. From Figma, the Name, Last 4, and Limit should all sit on a common baseline. |
@nkdengineer sorry for the trouble but this is something we did not catch in the PR so I should assign you here, can you please comment? |
I'm here |
@DylanDylann, @mountiny, @Expensify/design here is the result from my side, it seems they are not on the same line and are about 1-2px different |
Agree with the comments above. Hopefully it's a quick fix! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Issue found when executing PR #52529
Action Performed:
Precondition:
Expected Result:
User name, last 4 digits and limit amount will be aligned on the same line
Actual Result:
User name, last 4 digits and limit amount are not aligned on the same line (please refer to screenshot)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: