Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-26] [HOLD for payment 2024-11-22] Expense - The app crashes when deleting an error about creating a distance expense #52560

Closed
3 of 8 tasks
IuliiaHerets opened this issue Nov 14, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5222476
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open New Expensify app
  2. Log in with a new HT account
  3. Create a WS
  4. Go to the WS room
  5. Disconnect the internet
  6. Click + Menu > Submit expense
  7. Select Distance option
  8. Enter a vague start location, random characters should also work
  9. Enter a vague finish location, random characters should also work
  10. Finish the submit creation flow
  11. Turn on the internet
  12. Remove the distance expense creation error

Expected Result:

If the error about creating a distance expense is cleared, the application should crash.

Actual Result:

The app crashes when deleting an error about creating a distance expense

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6665161_1731587586874.Recording__226.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @puneetlath
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 14, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 14, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Nodebrute
Copy link
Contributor

same rca as #52542

@allgandalf
Copy link
Contributor

This will be fixed in #52547

@mountiny
Copy link
Contributor

@allgandalf, can you please link this issue to your PR and include tests for this so QA can confirm once CPed?

@allgandalf
Copy link
Contributor

Done updated @mountiny

@mountiny mountiny added the Reviewing Has a PR in review label Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@allgandalf
Copy link
Contributor

@puneetlath this was fixed in #52547, please ask QA to retest and close this issue, thanks !

@puneetlath
Copy link
Contributor

Yep, asked.

@kavimuru
Copy link

Not reproducible in 9.0.62-4

Recording.227.mp4

@puneetlath
Copy link
Contributor

Great, thanks!

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Nov 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Hourly KSv2 labels Nov 15, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 15, 2024
@melvin-bot melvin-bot bot changed the title Expense - The app crashes when deleting an error about creating a distance expense [HOLD for payment 2024-11-22] Expense - The app crashes when deleting an error about creating a distance expense Nov 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 15, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-22. 🎊

Copy link

melvin-bot bot commented Nov 15, 2024

@puneetlath / @johnmlee101 @puneetlath @puneetlath / @johnmlee101 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-22] Expense - The app crashes when deleting an error about creating a distance expense [HOLD for payment 2024-11-26] [HOLD for payment 2024-11-22] Expense - The app crashes when deleting an error about creating a distance expense Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-26. 🎊

Copy link

melvin-bot bot commented Nov 19, 2024

@puneetlath / @johnmlee101 @puneetlath @puneetlath / @johnmlee101 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants