[$250] Track expense - Back button returns to expense report after submitting track expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
   2.Go to self DM.
2. Track a manual expense.
3. Go to expense report.
4. Tap on the header.
5. Tap Submit to someone.
6. Select any user and submit it.
7. Tap app back button.

Expected Result:

App will return to self DM because the expense is submitted and therefore should be removed from the navigation path when returning to the previous page (self DM).

Actual Result:

App returns to the track expense. It only returns to self DM on second tap on the back button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6657589_1730984970085.ScreenRecording_11-07-2024_21-01-04_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854844368006624450
• Upwork Job ID: 1854844368006624450
• Last Price Increase: 2024-11-15

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twisterdotcom]

I just set myself as OOO for the day, apologies - handling some sickness. Going to re-add BUG here.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

👋🏼

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854844368006624450

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Gonals]

This seems minor enough not to block deploy on (today is Friday, anyways). What do you think, @Julesssss?

[Julesssss]

I agree it's not major, but lets at least locate the regression first. Deploy won't be happening today so we have a bit of time.

[Julesssss]

@Gonals it sounds possibly related to this other issue

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Whoever identifies the offending PR gets $50 and we can revert

[daledah]

Edited by proposal-police: This proposal was edited at 2024-11-11 07:34:13 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Back button returns to expense report after submitting track expense

What is the root cause of that problem?

This is the new feature. Here is the PR that adds submit it to someone option

After creating the request, we have the logic to dismiss modal then navigate to the activeReportID

App/src/libs/actions/IOU.ts

Line 3709 in ba543d7

Navigation.dismissModal(isSearchTopmostCentralPane() ? undefined : activeReportID);

but we don't have the logic to remove the track expense report from navigation state

What changes do you think we should make in order to solve the problem?

Add the logic to remove track expense report in navigation state in this place

    const trackReport = navigationRef.getRootState().routes.find(r=>r.name === 'Report' && r.params?.['reportID'] === linkedTrackedExpenseReportAction?.childReportID)
    trackReport?.key && Navigation.removeScreenByKey(latestTrackReport?.key)

removeScreenByKey is quite same as removeScreenFromNavigationState, but we remove state by key instead of screen name

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2024-11-11.at.14.29.53.mov

[daledah]

@mountiny I just found the offending PR, but I think it's the new feature and we shouldn't revert it

[Gonals]

@eVoloshchak quick C+ review of the proposal here? 😁

[zanyrenney]

@twisterdotcom seeing as you're back and this wasn't daily, so I haven't contributed, going to unassign myself!

[dukenv0307]

@Gonals I can help review this issue if @eVoloshchak isn't available to review

[daledah]

@mountiny What do you think about my proposal? It's DB, so I can create the quick PR if it's selected

[mountiny]

I believe we agreed to demote this in Slack, so doing so

@Gonals and @eVoloshchak can handle the review process

[daledah]

@eVoloshchak What do you think about my proposal?

[melvin-bot]

@eVoloshchak, @twisterdotcom, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸