[HOLD for payment 2024-11-20] [Workspace Feeds] Only showing last 4 digits of card on card details page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): quality

Action Performed:

Prerequisite:
Members and company cards added in workspace , 8+ export options for card

1. Go to staging.new.expensify.com
2. Choose the workspace from settings
3. Click company cards >Card Details

Expected Result:

Card number supposed to be 10 digits showing

Actual Result:

Only 4 digits are showing

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence


View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[m-natarajan]

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

[melvin-bot]

Triggered auto assignment to @arosiclair (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

Handling this as part of the project I have worked on

[waterim]

Hello, Im Artem from Callstack and would like to help with this issue!

[waterim]

@mountiny wanted to be sure here
I can see that in figma we have dots in card names, but actual app has only XXXX format everywhere, should I use just the same name with XXXX for card details page, or only here will be with dots?

Figma:

Actual:

[waterim]

Created a PR with updating to an actual design as we have everywhere with XXXX

[DylanDylann]

@waterim the same bug on Expensify Card, I think we also should fix. About the masked number, I prefer to use dots instead of X. But let's wait for other confirmation

cc @mountiny @Expensify/design

[mountiny]

We discussed this internally and essentially XXX is how we mask it from BE and i dont think we should change this as it might effect old dot too

If we want to, we can do find and replace in App to show the dots instead if @Expensify/design feels strongly about it

[shawnborton]

I think the dots feel much cleaner and more polished, but I totally understand it's a subjective preference. Not sure if it's worth the squeeze but they do look nicer...

[mountiny]

@waterim I think it should be easy to make a helper method to use everywhere the masked number is used to replace the X with dot, could you please do that? I agree they look a bit better so lets do it

[waterim]

Yes, I can change it everywhere

[joekaufmanexpensify]

Yep, that sounds good to me!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace Feed - update details cardName to use full name instead of 4 digits #52151

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @Christinadobrzyn @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [NO QA]: Company card details #48491 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Go to company card page
2. Verify that card number supposed to be 10 digits showing in all places (Card Detail, assigned new card flow, wallet page). Ex: 1234 56** **** 1234

Do we agree 👍 or 👎

[Christinadobrzyn]

Moving to Daily since payment is coming up.

Payouts due:

• Reviewer: $250 @DylanDylann (upwork offer - https://www.upwork.com/nx/wm/offer/104963483)

[DylanDylann]

No need payment, let's close this issue