[Feature]: Add phone number to the private personal details section #50773

allgandalf · 2024-10-15T05:45:02Z

Details

Users need a phone number to issue physical Expensify cards. We ask them for the phone number in the form to ship the Expensify card, but otherwise, this phone number is not editable from NewDot. This is a problem in case they want to edit it after adding it for the Expensify card.

Fixed Issues

$ #50701
PROPOSAL: https://expensify.slack.com/archives/C02NK2DQWUX/p1728885017172809?thread_ts=1728884992.974789&cid=C02NK2DQWUX

Tests

Open App
Go to settings > profile
In private details, click on Phone Number

Verify that: you are able to enter phone number and styling is correct, and verify that error is displayed on wrong entry

Verify that no errors appear in the JS console

Offline tests

Open App
Go to settings > profile
In private details, click on Phone Number

Verify that: you are able to enter phone number and in offline mode the number is displayed

QA Steps

Open App
Go to settings > profile
In private details, click on Phone Number

Verify that: you are able to enter phone number and styling is correct, and verify that error is displayed on wrong entry

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-15.at.12.12.00.PM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-15.at.11.51.59.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-15.at.12.08.57.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-15.at.11.48.38.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-15.at.11.54.51.AM.mov

melvin-bot · 2024-10-15T05:45:07Z

@dubielzyk-expensify @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/settings/Profile/PersonalDetails/PhoneNumberPage.tsx

src/libs/API/types.ts

src/libs/actions/PersonalDetails.ts

dubielzyk-expensify · 2024-10-16T00:16:51Z

I think the label should simply say Phone number instead of What's your phone number:

I also find the adding of the +1 after the fact a bit odd. Is this something we do in the rest of the app? cc @Expensify/design

shawnborton · 2024-10-16T07:33:33Z

Yup, agree with Jon's comments.

Regarding the country code... yeah, that's an interesting one. Do we need to do that automatically or can we just rely on the user to enter one if needed?

allgandalf · 2024-10-16T08:32:43Z

Regarding the country code... yeah, that's an interesting one. Do we need to do that automatically or can we just rely on the user to enter one if needed?

The country code is added by the BE automatically even when the user submits only number, so if we want to change that, we need to update the BE

allgandalf · 2024-10-16T08:39:33Z

I think the label should simply say Phone number instead of What's your phone number:

Fixed!

dubielzyk-expensify · 2024-10-17T04:00:44Z

The country code is added by the BE automatically even when the user submits only number, so if we want to change that, we need to update the BE

I think the execution of this feels a bit inelegant, but I get why it's done this way. It kinda feels like there should be a country selector on that screen that'd defaulted to their location. But I also feel like all this is something worth solving later.

Thoughts @Expensify/design ?

mountiny · 2024-10-17T06:08:35Z

Yeah I think we could improve this with some dedicated country code selector, but I would say that is something for later.

@allgandalf @DylanDylann For FE validation, lets use the same as in the card shipping flow.

For handling BE errors, show them using RBR dot on the row in the Private setting and then under the input with X to clear it

allgandalf · 2024-10-17T06:11:14Z

For handling BE errors, show them using RBR dot on the row in the Private setting and then under the input with X to clear it

~~There would be some confusing error for this case, @DylanDylann tested out a Vietnamese number yesterday and the BE returned not valid email, is that alright?~~

We came to conclusion on slack

@allgandalf @DylanDylann For FE validation, lets use the same as in the card shipping flow.

Yeah using that already

shawnborton · 2024-10-17T07:56:39Z

Yeah I agree with Jon that it doesn't feel the nicest, but I also see the point that if it ain't broke... we can revisit that particular part of the flow later.

dannymcclain · 2024-10-17T13:53:04Z

I'm in line with the comments above. A dedicated country picker would be nice on that screen, but I also agree that we don't need to do it right this second.

DylanDylann · 2024-10-22T02:05:27Z

@allgandalf Let's add a padding-top on error message to ensure a space 8px as form error message

DylanDylann · 2024-10-22T02:09:10Z

Let's add RBR on Profile tab and avatar tab when there is a error

DylanDylann · 2024-10-22T02:10:09Z

@allgandalf 2 error messages are displayed at the same time

DylanDylann · 2024-10-24T02:21:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-24.at.09.22.00.mov

Android: mWeb Chrome

Screen.Recording.2024-10-24.at.09.19.33.mov

iOS: Native

Screen.Recording.2024-10-24.at.09.22.19.mov

iOS: mWeb Safari

Screen.Recording.2024-10-24.at.09.18.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.09.17.16.mov

MacOS: Desktop

Screen.Recording.2024-10-24.at.09.20.26.mov

dubielzyk-expensify · 2024-10-24T03:10:38Z

The behavior in this video looks good to me. The last video posted doesn't seem to save the number which is a bit odd.

shawnborton · 2024-10-24T06:25:14Z

Which video particularly Jon? It looks like the two videos posted here are working as expected at least.

dannymcclain · 2024-10-24T13:36:30Z

Which video particularly Jon? It looks like the two videos posted #50773 (comment) are working as expected at least.

Both the videos are looking correct to me as well.

dannymcclain · 2024-10-24T13:38:12Z

OH I see what Jon is saying. In the failure video here, we're not saving the "bad" phone number the user entered. Is that expected?

shawnborton · 2024-10-24T16:01:19Z

Ah, is that because it was considered a "bad" number from the backend? I have no idea how that works TBH.

dubielzyk-expensify · 2024-10-25T00:04:48Z

Yeah, I guess I was expecting it to save and show even though it throws an error. Happy to move forward as you've got control 👍

DylanDylann · 2024-10-25T04:08:22Z

src/pages/settings/Profile/PersonalDetails/PhoneNumberPage.tsx

+        }
+
+        // Only call the API if the user has changed their phone number
+        if (phoneNumber !== values?.phoneNumber) {


I think we should move thí check to above validateLoginError

DylanDylann · 2024-10-25T04:09:11Z

@allgandalf BUG: 2 error messages are display at the same time

Screen.Recording.2024-10-25.at.11.08.28.mov

allgandalf · 2024-10-25T07:27:56Z

@allgandalf BUG: 2 error messages are display at the same time

@DylanDylann fixed!

src/hooks/useIndicatorStatus.ts

src/pages/settings/InitialSettingsPage.tsx

src/libs/UserUtils.ts

Co-authored-by: Vit Horacek <[email protected]>

allgandalf · 2024-10-28T12:31:02Z

Works well after update:

Screen.Recording.2024-10-28.at.5.55.20.PM.mov

mountiny

Thank you, easy-peasy 😂

OSBotify · 2024-10-28T12:47:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-29T09:44:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-10-31T11:17:28Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.55-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

add phoneNumber RHP to private details page

0306beb

allgandalf requested a review from a team as a code owner October 15, 2024 05:45

melvin-bot bot requested review from dubielzyk-expensify and DylanDylann and removed request for a team October 15, 2024 05:45

allgandalf commented Oct 15, 2024

View reviewed changes

src/pages/settings/Profile/PersonalDetails/PhoneNumberPage.tsx Show resolved Hide resolved

allgandalf commented Oct 15, 2024

View reviewed changes

src/libs/API/types.ts Outdated Show resolved Hide resolved

allgandalf added 4 commits October 15, 2024 11:25

fix lint and import UpdateLegalNameParams as type

f90cc5d

Delete src/pages/settings/Profile/PersonalDetails/test.md

d017a85

update to correct api command

a33bf2d

fix typecheck, add update phone number to write command

47b3dc9

allgandalf changed the title ~~add phoneNumber RHP to private details page~~ [Feature]: Add phone number to the private personal details section Oct 15, 2024

DylanDylann reviewed Oct 15, 2024

View reviewed changes

src/libs/actions/PersonalDetails.ts Show resolved Hide resolved

src/libs/actions/PersonalDetails.ts Outdated Show resolved Hide resolved

change the input header for phone number

9446f6a

mountiny assigned allgandalf Oct 16, 2024

allgandalf added 2 commits October 21, 2024 21:09

add BE error RBR and error field to phone number

53d430a

fix eslint

5f274bb

allgandalf added 2 commits October 24, 2024 11:57

fix lint

89b1f44

return early if no error is present

3c927e2

DylanDylann reviewed Oct 25, 2024

View reviewed changes

allgandalf added 3 commits October 25, 2024 12:18

Merge branch 'Expensify:main' into newPhoneNumberRHPForProfile

6a32dea

delete md file

d0fb1b5

clear BE error on validation

f539c52

DylanDylann approved these changes Oct 25, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 25, 2024 08:58

allgandalf added 2 commits October 27, 2024 16:48

Merge branch 'Expensify:main' into newPhoneNumberRHPForProfile

7e4239e

fix lint

e532ef1

DylanDylann approved these changes Oct 28, 2024

View reviewed changes

mountiny requested changes Oct 28, 2024

View reviewed changes

Apply suggestions from code review

c07af88

Co-authored-by: Vit Horacek <[email protected]>

mountiny approved these changes Oct 28, 2024

View reviewed changes

mountiny merged commit 4d65cc7 into Expensify:main Oct 28, 2024
16 checks passed

github-actions bot mentioned this pull request Oct 29, 2024

Deploy Checklist: New Expensify 2024-10-29 #51635

Closed

65 tasks

melvin-bot bot mentioned this pull request Oct 31, 2024

[HOLD for payment 2024-11-07] Add phone number to the private personal details section #50701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature]: Add phone number to the private personal details section #50773

[Feature]: Add phone number to the private personal details section #50773

allgandalf commented Oct 15, 2024 •

edited

Loading

melvin-bot bot commented Oct 15, 2024

dubielzyk-expensify commented Oct 16, 2024

shawnborton commented Oct 16, 2024

allgandalf commented Oct 16, 2024

allgandalf commented Oct 16, 2024

dubielzyk-expensify commented Oct 17, 2024

mountiny commented Oct 17, 2024

allgandalf commented Oct 17, 2024 •

edited

Loading

shawnborton commented Oct 17, 2024

dannymcclain commented Oct 17, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 24, 2024 •

edited

Loading

dubielzyk-expensify commented Oct 24, 2024

shawnborton commented Oct 24, 2024

dannymcclain commented Oct 24, 2024

dannymcclain commented Oct 24, 2024

shawnborton commented Oct 24, 2024

dubielzyk-expensify commented Oct 25, 2024

DylanDylann Oct 25, 2024

DylanDylann commented Oct 25, 2024

allgandalf commented Oct 25, 2024

allgandalf commented Oct 28, 2024

mountiny left a comment

OSBotify commented Oct 28, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

[Feature]: Add phone number to the private personal details section #50773

[Feature]: Add phone number to the private personal details section #50773

Conversation

allgandalf commented Oct 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 15, 2024

dubielzyk-expensify commented Oct 16, 2024

shawnborton commented Oct 16, 2024

allgandalf commented Oct 16, 2024

allgandalf commented Oct 16, 2024

dubielzyk-expensify commented Oct 17, 2024

mountiny commented Oct 17, 2024

allgandalf commented Oct 17, 2024 • edited Loading

shawnborton commented Oct 17, 2024

dannymcclain commented Oct 17, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 22, 2024

DylanDylann commented Oct 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dubielzyk-expensify commented Oct 24, 2024

shawnborton commented Oct 24, 2024

dannymcclain commented Oct 24, 2024

dannymcclain commented Oct 24, 2024

shawnborton commented Oct 24, 2024

dubielzyk-expensify commented Oct 25, 2024

DylanDylann Oct 25, 2024

Choose a reason for hiding this comment

DylanDylann commented Oct 25, 2024

allgandalf commented Oct 25, 2024

allgandalf commented Oct 28, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 28, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

allgandalf commented Oct 15, 2024 •

edited

Loading

allgandalf commented Oct 17, 2024 •

edited

Loading

DylanDylann commented Oct 24, 2024 •

edited

Loading