Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed
71 tasks done
github-actions bot opened this issue Oct 15, 2024 · 20 comments
Closed
71 tasks done

Deploy Checklist: New Expensify 2024-10-15 #50764

github-actions bot opened this issue Oct 15, 2024 · 20 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Release Version: 9.0.49-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 15, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.49-0 🚀

@lakchote
Copy link
Contributor

Demoted #50777 for this reason.

@mvtglobally
Copy link

Regression at 55% completed

Blockers
#50722
#50771
#50774
#50778
#50779

@mjasikowski
Copy link
Contributor

#50779 demoted - minor UI issue

@mvtglobally
Copy link

Team got IOS build and Starting to cover the slots. We will be updating PRs and overall progress accordingly.

@NikkiWines
Copy link
Contributor

Demoting #50829, reproducible on prod

@mvtglobally
Copy link

Regression is at 10% left

Blockers
#50670
#50771
#50774
#50778
#50830

PRs
Most of PRs pending Android validation. Working through the list on the provided APK file.

@mvtglobally
Copy link

mvtglobally commented Oct 16, 2024

Regression is at 1% left

Blockers
#50670
#50771
#50774
#50778
#50830
#50872

Unchecked PRs

#49837 is failing with #50785. Repro in PROD, checking off
#49910 - Pending validation on Android
#50045 - Pending validation on Android and failing with #50824
#50047 is failing with #50839. Repro in PROD, checking off
#50228 - Pending validation on Android
#50234 - Pending validation on Web/Desktop
#50239 - Pending validation on Android and failing with #50826
#50297 - Pending validation on Web/Desktop
#50331 - Is failing logging issue in a few
#50337 - Pending validation on Android
#50427 - is failing with #50861
#50433 - Pending validation on Android
#50519 - Is failing with #50843 & #50403
#50597 - Pending validation on Android
#50619 - Pending validation on Android
#50638 - Pending validation on Android
#50643 - Pending validation on Android
#50645 - Pending validation on Android
#50706 - Pending validation on Android
#50707 - Pending validation on Android
#50795 - Pending validation on all platforms

@marcaaron
Copy link
Contributor

#50830 was closed as a non-issue

@marcaaron
Copy link
Contributor

#50778 was fixed

@marcaaron
Copy link
Contributor

Removed the blocker on #50670. The crash can't be tied to any recent changes and it is no longer reproducible so I am assuming the impacts are not great.

@marcaaron
Copy link
Contributor

Removing blocked on #50774 since this is behind a beta.

@marcaaron
Copy link
Contributor

Removing blocker on #50872 as it is an API issue

@marcaaron
Copy link
Contributor

Checking off #50771 as the issue was resolved with a CP

@mvtglobally
Copy link

Can you pls run the following QBD PRs internally. We are stuck at the setup and credentials setup is still in works. It will help expedite checklist
#50234
#50297

@mvtglobally
Copy link

mvtglobally commented Oct 17, 2024

Regression is completed

Unchecked PRs
#50234 (comment) - Can you QA internally?
#50239 - failing with #50826
#50297 - Can you QA internally?
#50331 - Is failing with #50920. Repro on PrOD checking off.
#50645 - pass on Web/Desktop. On Hybrid app new Gmail stays on OldDot. Can we check this off?
#50795 - Pending validation on Desktop as we didn't get build yet. Pass on the rest of platforms
#50870 - checking CP

@marcaaron
Copy link
Contributor

Since the QBD stuff is behind a beta I am going to ping @lakchote to assist with the QA whenever he returns. I don't think we need to block the deploy on this.

@marcaaron
Copy link
Contributor

On Hybrid app new Gmail stays on OldDot. Can we check this off?

Have a bug report or something? Didn't quite catch this.

@mvtglobally
Copy link

mvtglobally commented Oct 17, 2024

@marcaaron it is expected behavior. When user registers on Hybrid app, option to Try ND is not displayed.
As per PR steps, we need to create a new user.

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants