Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Crash when kill the app and reopen it #50463

Open
1 of 6 tasks
lanitochka17 opened this issue Oct 8, 2024 · 34 comments
Open
1 of 6 tasks

[$250] Android - Crash when kill the app and reopen it #50463

lanitochka17 opened this issue Oct 8, 2024 · 34 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Install the New dot app
  2. Open android app
  3. Login with new gmail account
  4. Complete the onboarding modal
  5. Kill the app
  6. Open the app

Expected Result:

App should open

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6628394_1728395962594.Recording__4245.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843775413325774813
  • Upwork Job ID: 1843775413325774813
  • Last Price Increase: 2024-11-05
Issue OwnerCurrent Issue Owner: @DylanDylann
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@srikarparsi
Copy link
Contributor

Not able to reproduce on my physical ios device with a new account. Going to try on android emulator.

@thienlnam
Copy link
Contributor

thienlnam commented Oct 8, 2024

There's been an emerging crash in firebase that looks like it might be related here
com.expensify.chat_issue_4f8a216f0a769e684d009b28ef9bd7d4_crash_session_6705473302F5000179E748FD60E92734_DNE_0_v2_stacktrace.txt

SurfaceMountingManager.getViewState

Appears to be present in a few different versions, so maybe not a deploy blocker

@thienlnam
Copy link
Contributor

Potentially related: facebook/react-native#38743

@thienlnam
Copy link
Contributor

@kirillzyusko Do you think this #37891 would address this crash as well?

@thienlnam thienlnam changed the title Android - Crash when kill the app and reopen it [HOLD #50482] Android - Crash when kill the app and reopen it Oct 8, 2024
@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 8, 2024
@srikarparsi
Copy link
Contributor

I'm not able to reproduce on an emulator in production
https://github.com/user-attachments/assets/7a55635c-6cfa-4014-8dc1-3d6b43938a9d

@srikarparsi
Copy link
Contributor

I am able to reproduce on staging. But reopening the app does work so it doesn't continually crash. Future quit/reopens don't crash the app either.
https://github.com/user-attachments/assets/ca340a7e-ccd4-417d-93d6-916f02cd59a8

@thienlnam
Copy link
Contributor

Hmm, this crash has been happening quite a bit - perhaps we can get some eyes on this?

@thienlnam thienlnam added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Current assignee @srikarparsi is eligible for the DeployBlockerCash assigner, not assigning anyone new.

@thienlnam thienlnam changed the title [HOLD #50482] Android - Crash when kill the app and reopen it Android - Crash when kill the app and reopen it Oct 8, 2024
@melvin-bot melvin-bot bot changed the title Android - Crash when kill the app and reopen it [$250] [HOLD #50482] Android - Crash when kill the app and reopen it Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021843775413325774813

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

@github-actions github-actions bot added the Hourly KSv2 label Oct 8, 2024
@thienlnam thienlnam changed the title [$250] [HOLD #50482] Android - Crash when kill the app and reopen it [$250] Android - Crash when kill the app and reopen it Oct 8, 2024
@kirillzyusko
Copy link
Contributor

Do you think this #37891 would address this crash as well?

I tested and in my case it still crashes 😔

@mountiny
Copy link
Contributor

mountiny commented Oct 9, 2024

@thienlnam from the firebase, it seems like this was happening in previous builds, too. Should we demote?

@thienlnam
Copy link
Contributor

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

@srikarparsi, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@DylanDylann
Copy link
Contributor

DylanDylann commented Oct 16, 2024

Still waiting for proposals

Note for contributors about the discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1728553588654189?thread_ts=1728413409.127509&cid=C01GTK53T8Q

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@srikarparsi, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@DylanDylann
Copy link
Contributor

Still waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Oct 25, 2024

@srikarparsi, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@srikarparsi
Copy link
Contributor

srikarparsi commented Oct 29, 2024

No update yet, going to add the bug label for Bug-Zero eyes as we're still looking for proposals

@srikarparsi srikarparsi added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
@srikarparsi
Copy link
Contributor

Related to #50482

Copy link

melvin-bot bot commented Oct 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Nov 1, 2024

@anmurali, @srikarparsi, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@srikarparsi
Copy link
Contributor

Discussing here

Copy link

melvin-bot bot commented Nov 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Nov 5, 2024

@anmurali @srikarparsi @DylanDylann this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Nov 5, 2024

@anmurali, @srikarparsi, @DylanDylann 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue
Projects
None yet
Development

No branches or pull requests

7 participants