-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search - Some of the expense amounts are truncated #49930
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Search - Some of the expense amounts are truncated What is the root cause of that problem?We are not passing numberOfLines={0} below, and the amount is truncated since the defaultNumberOfLines = 1 App/src/components/SelectionList/Search/TransactionListItemRow.tsx Lines 166 to 169 in 0e3b82c
What changes do you think we should make in order to solve the problem?We should pass numberOfLines={0} What alternative solutions did you explore? (Optional)We can assign numberOfLines 0 for only small screens since there is tooltip for large screens
ResultScreen.Recording.2024-09-30.at.4.45.54.in.the.afternoon.mp4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Search - Some of the expense amounts are truncated What is the root cause of that problem?We use What changes do you think we should make in order to solve the problem?We should change to
What alternative solutions did you explore? (Optional) |
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Expense amounts should be fully visible
Actual Result:
Some of the expense amounts are truncated. Android is more affected than web or desktop. Different expenses are truncated on different environments. Short and long amounts can be both truncated
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6618645_1727542220559.bandicam_2024-09-28_18-41-12-732.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: