Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Some of the expense amounts are truncated #49930

Open
3 of 6 tasks
lanitochka17 opened this issue Sep 30, 2024 · 4 comments
Open
3 of 6 tasks

Search - Some of the expense amounts are truncated #49930

lanitochka17 opened this issue Sep 30, 2024 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an old account that has a lot of expenses
  3. Click on "Search"
  4. Scroll down

Expected Result:

Expense amounts should be fully visible

Actual Result:

Some of the expense amounts are truncated. Android is more affected than web or desktop. Different expenses are truncated on different environments. Short and long amounts can be both truncated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6618645_1727542220559.bandicam_2024-09-28_18-41-12-732.mp4

4255_New_Expensify

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@etCoderDysto
Copy link
Contributor

etCoderDysto commented Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Some of the expense amounts are truncated

What is the root cause of that problem?

We are not passing numberOfLines={0} below, and the amount is truncated since the defaultNumberOfLines = 1

<TextWithTooltip
shouldShowTooltip={showTooltip}
text={amount}
style={[styles.optionDisplayName, styles.justifyContentCenter, isLargeScreenWidth ? undefined : styles.textAlignRight]}

What changes do you think we should make in order to solve the problem?

We should pass numberOfLines={0}

What alternative solutions did you explore? (Optional)

We can assign numberOfLines 0 for only small screens since there is tooltip for large screens

numberOfLines={isLargeScreenWidth ? 1 : 0}
Result
Screen.Recording.2024-09-30.at.4.45.54.in.the.afternoon.mp4

@nyomanjyotisa
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Some of the expense amounts are truncated

What is the root cause of that problem?

We use styles.flex1 for the total cell container, so the width of the container will be not enough for large amount

What changes do you think we should make in order to solve the problem?

We should change to styles.flex2

<View style={[styles.alignItemsEnd, styles.flex1, styles.gap1, styles.justifyContentBetween]}>

What alternative solutions did you explore? (Optional)

@etCoderDysto
Copy link
Contributor

Proposal updated

  • Added result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants