Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search-New SearchButton has not been added #49785

Closed
2 of 6 tasks
lanitochka17 opened this issue Sep 26, 2024 · 4 comments
Closed
2 of 6 tasks

Search-New SearchButton has not been added #49785

lanitochka17 opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.40
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49379

Action Performed:

  1. Verify that the button to trigger new search is displayed on every page
  2. Verify that clicking the button opens new search router
  3. Verify that search router works - it should navigate to search with specific query

Expected Result:

The button to trigger new search is displayed

Actual Result:

The button to trigger a new search is not displayed on any screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6615496_1727310749542.49379-mWeb.mp4
Bug6615496_1727310749548.49379-Web.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Nodebrute
Copy link
Contributor

Nodebrute commented Sep 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

New SearchButton has not been added

What is the root cause of that problem?

We only show search button in development mode

function canUseNewSearchRouter() {
return Environment.isDevelopment();
}

What changes do you think we should make in order to solve the problem?

If search button development is complete and we are ready to use it. we can remove this code block

function canUseNewSearchRouter() {
return Environment.isDevelopment();
}

What alternative solutions did you explore? (Optional)

@Kicu
Copy link
Contributor

Kicu commented Sep 30, 2024

The displaying of new Search button only in dev was a deliberate decision. It was impossible to work on the new SearchRouter without merging some code to main first, but we were not able to implement the whole Search 2.4 solution in one go - it was too complex.

We can enable the new Search button after these are merged:

Without these PRs the search v2.4 offers quite inferior experience in my opinion.
FYI @luacmartins please take a look

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@luacmartins
Copy link
Contributor

I agree. We can just close this issue, we'll add the button once the feature is ready

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants