[Create Money Request] Update iouReport optimistically

[grgia]

Context

Follow up to #49172

Reported here: #49172 (comment)

Steps Taken

MULTI TRANSACTIONS FROM DIFFERENT USERS (IOU) AVATAR CASE

1. Log into user B in a separate session
2. Send a money request from user B
3. Verify that report preview avatar is both avatars, user A and B
4. Verify that report preview title is &
5. Both preview avatar and title are incorrect.

Expected Result:
Report preview avatar is both avatars, user A and B

Actual Result:
Report preview avatar is still only user A until refresh

Video

Screen.Recording.2024-09-25.at.10.29.44.PM.mov

Screen.Recording.2024-09-25.at.9.48.46.PM.mov

Solution

I think this is probably an issue with updating the iouReport data optimistically when the IOU is made.
https://github.com/Expensify/App/blob/main/src/libs/actions/IOU.ts#L1998

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

Checking to see if this is same/similar to what Cole reported
https://expensify.slack.com/archives/C01SKUP7QR0/p1727461394841889?thread_ts=1727360298.835599&cid=C01SKUP7QR0

[melvin-bot]

@mallenexpensify, @grgia, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify, @grgia, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Throwing on #wave-collect cuz the other avatar-related issue was on the same. And.. the bug affects collect users.
@grgia is working on avatars, few issues for 'em out there, bumping to weekly.

[melvin-bot]

@mallenexpensify @grgia @eh2077 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[grgia]

not overdue, this is polish

[mallenexpensify]

@grgia is working on. Gonna drop in Quality project for now

[grgia]

I haven't jumped back into this as I was working on some higher priority quality issues, but still planning to look into a solution here

[mallenexpensify]

I'm back from OOO on Nov 14th, not assigning another BZ because it's working being worked on internally and payment won't be due til after I'm back. If one is needed please add or post in #contributor-plus to ask for one to be added, thx.

[grgia]

Yeah I haven't had a chance to take this, I think I may unassign for now if we still think we should fix this

[mallenexpensify]

@grgia , this needs to be Internal, right? It looks like it's Medium for #quality so it might fall into the bucket of not highest priority for you and others. It's not AutoAssignerNewDotQuality so you can unassign if you don't think it's valuable to fix