Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending / Scanning] Message containing a report says it is from the workspace name instead of the cardholder's name #49036

Closed
1 of 6 tasks
m-natarajan opened this issue Sep 12, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726081403491199

Action Performed:

  1. Get assigned a >$0 limit on cardtest.expensify.com domain
  2. Navigate to NewDot in your test account, and go to Settings > Wallet > Expensify Card > Reveal details (on virtual card)
  3. Navigate to this paypal link and select “buy” on the first button on that screen, and use your virtual card details to make the purchase.
  4. Check workspace chat

Expected Result:

Cardholder's name displayed in report

Actual Result:

Message containing a report says it is from the workspace name. Same issue observed for IOUs as well

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image (7)

image (8)

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@kevinksullivan kevinksullivan moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Sep 12, 2024
@kevinksullivan kevinksullivan changed the title Message containing a report says it is from the workspace name instead of the cardholder's name [Pending / Scanning] Message containing a report says it is from the workspace name instead of the cardholder's name Sep 12, 2024
@kevinksullivan kevinksullivan moved this from Release 2: Summer 2024 (Aug) to Release 2.5: SuiteWorld (Sept 9th) in [#whatsnext] #wave-collect Sep 12, 2024
@kevinksullivan
Copy link
Contributor

Discussing broader expected behavior here

https://expensify.slack.com/archives/C036QM0SLJK/p1726064302069299

@grgia grgia self-assigned this Sep 12, 2024
@grgia
Copy link
Contributor

grgia commented Sep 13, 2024

@grgia
Copy link
Contributor

grgia commented Sep 13, 2024

Pasting from slack:

Seems the issue might is from this line here, which is causing the second part of this line to always be true

 const isWorkspaceActor = isInvoiceReport || (ReportUtils.isPolicyExpenseChat(report) && (!actorAccountID || displayAllActors));

@grgia
Copy link
Contributor

grgia commented Sep 13, 2024

@grgia
Copy link
Contributor

grgia commented Sep 13, 2024

The actor account ID in onyx is correct, but we're using the wrong data here

@trjExpensify trjExpensify added Internal Requires API changes or must be handled by Expensify staff and removed Needs Reproduction Reproducible steps needed labels Sep 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@grgia
Copy link
Contributor

grgia commented Sep 18, 2024

Question posted here

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 20, 2024
@miljakljajic
Copy link
Contributor

I am heading out on parental leave - seems like this is being handled entirely internally, so I won't assign another BZ team member. @grgia stick someone else on it if I'm wrong!

@miljakljajic miljakljajic removed their assignment Sep 20, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Oct 31, 2024

This issue has not been updated in over 15 days. @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@grgia
Copy link
Contributor

grgia commented Nov 1, 2024

Closing as complete

@grgia grgia closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
No open projects
Status: Release 2.5: SuiteWorld (Sept 9th)
Development

No branches or pull requests

6 participants