[HOLD for payment 2024-09-18] [$125] Bank account - Company website field is blank on confirmation page if it is not modified

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.30-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Account is a private domain account (Expensifail).

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows
3. Click Connect bank account > Connect manually
4. Proceed to Step 4 - Enter Company's Tax ID page
5. Enter Tax ID > Next
6. Note that the website field is auto populated with https://www.applause.expensifail.com/
7. Click Next without changing the website field.
8. Proceed to confirmation page for Company info.
9. Click Confirm.

Expected Result:

In Step 8, Company website field should be filled with the auto-populated website in Step 6.

Actual Result:

In Step 8, Company website field is not filled with the auto-populated website in Step 6.
In Step 9, after clicking Confirm, it shows the error "Please provide a valid Website" when the field is auto-populated with a valid website.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594679_1725574349282.bank.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831968301055311769
• Upwork Job ID: 1831968301055311769
• Last Price Increase: 2024-09-09

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[madmax330]

Looks like we're not rendering the default value. I think this is a front-end issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831968301055311769

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-09-06 08:48:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, Company website field is not filled with the auto-populated website in Step 6.
In Step 9, after clicking Confirm, it shows the error "Please provide a valid Website" when the field is auto-populated with a valid website.

What is the root cause of that problem?

Input's default value is not saved into draft unless user changes value.

We only save draft in onInputChange:

App/src/components/Form/FormProvider.tsx

Lines 371 to 373 in d9618ca

	if (inputProps.shouldSaveDraft && !formID.includes('Draft')) {
	FormActions.setDraftValues(formID, {[inputKey]: value});
	}

What changes do you think we should make in order to solve the problem?

We should save draft whenever we use the default values:

App/src/components/Form/FormProvider.tsx

Lines 263 to 269 in d9618ca

	} else if (inputProps.shouldUseDefaultValue && inputProps.defaultValue !== undefined && inputValues[inputID] === undefined) {
	// We force the form to set the input value from the defaultValue props if there is a saved valid value
	inputValues[inputID] = inputProps.defaultValue;
	} else if (inputValues[inputID] === undefined) {
	// We want to initialize the input value if it's undefined
	inputValues[inputID] = inputProps.defaultValue ?? getInitialValueByType(inputProps.valueType);
	}

We can write a dedicated function to save draft with the following logic since we use it many times:

App/src/components/Form/FormProvider.tsx

Lines 371 to 373 in d9618ca

	if (inputProps.shouldSaveDraft && !formID.includes('Draft')) {
	FormActions.setDraftValues(formID, {[inputKey]: value});
	}

[bernhardoj]

This happens after we re-enable the auto-populate default website here which was previously temporarily disabled. I think I missed the logic to save it to the draft, I'll recheck it later.

[mountiny]

@bernhardoj is the PR author with the fix @brunovjk is not online so @hungvu193 will handle the PR review

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

$125 payment to @hungvu193 only

[brunovjk]

@bernhardoj is the PR author with the fix @brunovjk is not online so @hungvu193 will handle the PR review

I didn't notice any ping/tag about this before. Thanks for handling it @mountiny.

[greg-schroeder]

All right - well once this is finished up, the payment summary is simply:

C+: @hungvu193 - $250 - you can make a manual request in ND

[hungvu193]

Requested on ND

[greg-schroeder]

All right then, closing as the payment summary is there and the request was made - payment approver can take a look here tomorrow 9/18 to confirm!

[garrettmknight]

$250 approved for @hungvu193