Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-01] [Improvement] Ensure New Expensify Supportal provides View access to all required information #48616

Closed
VictoriaExpensify opened this issue Sep 5, 2024 · 29 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@VictoriaExpensify
Copy link
Contributor

VictoriaExpensify commented Sep 5, 2024

Problem:

Currently, New Expensify Supportal is inconsistant with the information the support team member is able to view. All the information in the following locations looks good:

  • Search
  • Account Settings

The following information appears inconsistantly, or not at all:

  • Inbox
  • Workspace Set Up

Why is this important:
Without being able to view this information, the support team is essentially "flying blind" when a customer reaches out for support. This results in a poort customer experience as we cannot see what features the customer has enabled and we need to ask them to provide information that we should have access to.

Solution
Find an engineer to help us give View access to all parts of the customers account via New Supportal, with the exception of:

  • Chat threads
  • Virtual Card details
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@VictoriaExpensify
Copy link
Contributor Author

Examples:

INBOX
** [email protected] - from within the account:**
image
image

From Supportal:
image
image

WORKSPACE SETUP
[email protected] - from within the account:
See this spreadsheet and the screenshots linked here

For additional context, all information contained within the customers account should be viewable via New Supportal. The only exceptions to that are:

  • Chat threads
  • Virtual Card details

@VictoriaExpensify
Copy link
Contributor Author

@VictoriaExpensify
Copy link
Contributor Author

As discussed here, applying the Internal and Hot Picks labels

@VictoriaExpensify VictoriaExpensify added Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with labels Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 5, 2024
@VictoriaExpensify
Copy link
Contributor Author

This needs to be managed internally as external teams are not able to make updates to Supportal.

Anu - removing your assignment, I'm happy to be the BZ assignee for this one.

@VictoriaExpensify
Copy link
Contributor Author

Not overdue - will post in Engineering chat in the morning to see if we can find an Engineer

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Sep 10, 2024
@muttmuure muttmuure added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @tylerkaraszewski (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 10, 2024
@muttmuure muttmuure removed the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Sep 10, 2024
@muttmuure
Copy link
Contributor

muttmuure commented Sep 10, 2024

@VictoriaExpensify Tyler is working on higher priorities and can't get to this for a few weeks. Do you want to go ahead and post to #engineering-chat or WN and we'll see if we can get someone else?

@VictoriaExpensify
Copy link
Contributor Author

Thanks @muttmuure - I've already posted this to Engineering Chat

@VictoriaExpensify
Copy link
Contributor Author

Update Sept 11:
NewDotQuality auto-assigner assigned this to Tyler, but he is unable to work on this for a few weeks due to higher priorities. Posted to Engineering Chat, but no takers, so I'll keep working on finding an engineer.

I will start trying to recruit an engineer. If anyone in Conci knows an engineer who might be interested, please reach out to them (or me!)

@VictoriaExpensify VictoriaExpensify changed the title Ensure New Expensify Supportal provides View access to all required information [Improvement] Ensure New Expensify Supportal provides View access to all required information Sep 12, 2024
@maddylewis maddylewis removed the Daily KSv2 label Sep 12, 2024
@maddylewis
Copy link
Contributor

@muttmuure / @puneetlath -- I want to make sure we (the newdot support team) are handling these issues correctly.

here puneet confirmed internal tooling issues should be added to NewDot-Quality project board [Medium] + the Hot Picks label after posting in WN / trying to recruit in eng-chat.

however, it sounds like going through that process didn't end up assigning someone who had the bandwidth. what is the best path forward in that scenario?

would it make sense for the engineer assigned to adjust the K2 label from daily to weekly but keep it assigned? or, could the eng assigned communicate they can't working on this atm and reapply the auto-assigner to get someone else assigned?

These internal tooling improvements are crucial to effectively supporting customers using New Dot, so I want to make sure we're all on the same page. so lmk your thoughts! :)

@muttmuure
Copy link
Contributor

I was thinking more along the lines that if we can get someone else sooner, then we should. Typically an engineer will look at an issue and pick it up if it is unassigned. If it's assigned to someone already, most people assume it's going to be worked on soon.

We can reapply the label and ask the next person to work on it. That's OK too.

@thienlnam
Copy link
Contributor

Still need to investigate why the accounting tab thinks it is loading - I see that it's making a call to the endpoint OpenPolicyAccountingPage which should be whitelisted, but it seems to fail immediately

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@VictoriaExpensify
Copy link
Contributor Author

Thanks for continuing to investigate this @thienlnam. Accounting integration issues are one of the items that we troubleshoot the most, so having this info available in Supportal is super important. Let me know if there is anything I can do to assist :)

@VictoriaExpensify
Copy link
Contributor Author

Hey @thienlnam - any update on the issue with the accounting tab?

@thienlnam
Copy link
Contributor

Okay after some debugging I figured out the fix:

Was odd because it would say that the request to OpenPolicyAccountingPage completed in 0ms with no response. I originally thought it was because it was put into the sequential queue and because we failed to re-authenticate we never actually end up sending the request to read the accounting data. However the other requests worked, so I was wondering if there was something different with the commands and indeed there is another place where we need to whitelist commands in App

https://github.com/Expensify/App/blob/e74eb8e705bce3e8791e3eb043fe5cbb1cbaecea/src/libs/Network/NetworkStore.ts#L100C1-L119C2

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 22, 2024
@melvin-bot melvin-bot bot changed the title [Improvement] Ensure New Expensify Supportal provides View access to all required information [HOLD for payment 2024-11-01] [Improvement] Ensure New Expensify Supportal provides View access to all required information Oct 25, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-01. 🎊

Copy link

melvin-bot bot commented Oct 25, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
  • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@thienlnam] Determine if we should create a regression test for this bug.
  • [@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 31, 2024
@VictoriaExpensify
Copy link
Contributor Author

Oh, you're not a C+ @thienlnam ! 😆

This is all fixed and looking good:

2024-11-01_14-18-00
2024-11-01_14-18-08
2024-11-01_14-18-16
2024-11-01_14-18-23

Going ahead and closing this out (without payment, sorry Jack! haha)

@github-project-automation github-project-automation bot moved this from Support (HIGH) to Done in [#whatsnext] #retain Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

7 participants