[$250] WS switcher-Different back button behavior when creating workspace via + and Get started button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.21-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Account has no workspace.

1. Go to staging.new.expensify.com
2. Open workspace switcher.
3. Click + icon next to "Workspaces".
4. Click app back button on workspace editor page.
5. Note that app opens workspace switcher when returning from workspace editor after creating a workspace from workspace switcher.
6. Delete the workspace.
7. Go to Inbox.
8. Open workspace switcher.
9. Click Get started on "Create a workspace" modal.
10. Click app back button on workspace editor page.

Expected Result:

App will open workspace switcher when clicking app back button after creating workspace from Create a workspace" modal (should display the same behavior as when the + button is used).

Actual Result:

App returns to Account settings instead.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6574882_1723924338491.20240818_034344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013645bc6cec0aa80d
• Upwork Job ID: 1828169605427820408
• Last Price Increase: 2024-11-18

Issue Owner

Current Issue Owner: @mananjadhav

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-08-21 13:09:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Different back button behavior when creating workspace via + and Get started button

What is the root cause of that problem?

• We are passing the current activeRoute which is the workspace selector modal route(/workspace-switcher) to backTo param here
  

  App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

  Line 37 in 67ad466

  interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt('', '', false, false, activeRoute));

• Then, when back button is pressed, we navigate back to the active route (backTo) here if it is available
  

  App/src/pages/workspace/WorkspaceInitialPage.tsx

  Lines 412 to 421 in 8a35256

  	<HeaderWithBackButton
  	title={policyName}
  	onBackButtonPress={() => {
  	if (route.params?.backTo) {
  	Navigation.resetToHome();
  	Navigation.isNavigationReady().then(() => Navigation.navigate(route.params?.backTo as Route));
  	} else {
  	Navigation.dismissModal();
  	}
  	}}

What changes do you think we should make in order to solve the problem?

Following the same pattern used in WorkspaceCardCreateAWorkspace page, we shouldn't pass the active route (/workspace-switcher) to backTo param, and call createWorkspaceWithPolicyDraftAndNavigateToIt without any argument here. When there is no backTo param the else condition will execute -> then the modal will be closed -> and user will be navigated to workspace list page

App.createWorkspaceWithPolicyDraftAndNavigateToIt();

What alternative solutions did you explore? (Optional)

[JmillsExpensify]

Hmm interesting. I agree that's inconsistent. I think this comes down to whether we should move UP on pressing back or now. @marcaaron thoughts on this consideration? I can kind of see the argument that UP is a more valid action, so you should always be taken back to the workspace list.

[marcaaron]

Not too passionate about this one as it's a pretty specific set of actions the user will take to uncover this inconsistency and can't imagine anyone feeling too impeded by either result. Both bring you to a list of workspaces. Both lead to the option to create a new workspace if you choose to do that after you just created one (which is probably an uncommon action in any case).

Ignoring the rules of navigation for a second - I see the workspace selector as less of a "page" and almost more of a pop up selector menu from a UX POV so it doesn't really need to be something we can navigate back to.

[JmillsExpensify]

Ignoring the rules of navigation for a second - I see the workspace selector as less of a "page" and almost more of a pop up selector menu from a UX POV so it doesn't really need to be something we can navigate back to.

Cool, I agree with this. So then let's make sure that "back" goes to the workspace list for both of these cases.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013645bc6cec0aa80d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

@JmillsExpensify, @mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify @mananjadhav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @mananjadhav Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

Still waiting for proposals

[etCoderDysto]

I have a proposal here #47603 (comment)

[mananjadhav]

Cool, I agree with this. So then let's make sure that "back" goes to the workspace list for both of these cases.

@etCoderDysto Couldn't understand from your proposals if it covers the expected behavior ^

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Yes, the back button should navigate to the previous route. Sorry, missed this last week.

[melvin-bot]

@JmillsExpensify, @mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @mananjadhav 10 days overdue. I'm getting more depressed than Marvin.

[JmillsExpensify]

Not the highest priority, though I think we're still aligned that the back button is the previous route.

[melvin-bot]

@JmillsExpensify, @mananjadhav 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify, @mananjadhav eroding to Weekly issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

I'll review the proposals again on this one.

[etCoderDysto]

A gentle reminder to look at this comment when reviewing proposals.

Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JmillsExpensify]

Waiting on proposal review

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

Missed this one. I'll check this by tomorrow.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸