[HOLD for Payment 2024-09-06] [$250] Tag-After unselecting state option, region selected is shown in state field.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.19
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4848505
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-condition: Upload dependent tags as admin in old dot

1. Launch app
2. Tap on employee workspace chat
3. Tap plus icon -- submit expense
4. Enter an amount and tap next
5. Unselect State option
6. Select a Region option

Expected Result:

After unselecting state option, region selected must not be shown in state field.

Actual Result:

After unselecting state option, region selected is shown in state field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6570685_1723538351947.RC.mp4

Bug6570685_1723538561973!Dependent_-_Multi_Level_tags_NEW.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016dd65aecb20eb97f
• Upwork Job ID: 1823301758645340925
• Last Price Increase: 2024-08-13
• Automatic offers:
• shubham1206agra | Reviewer | 103580205
• situchan | Contributor | 103580206

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016dd65aecb20eb97f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[grgia]

It looks like this is related to dependent tags; demoted from deploy blocker

[grgia]

Or potentially categories. cc @trjExpensify could you confirm

[grgia]

I'm not sure what the expected behavior is here, looking to tag the project lead

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deselecting the state option, the selected region appears in the state field

What is the root cause of that problem?

We filter out the empty tag item here, it makes the tags string not properly formated. it removed the colon that should separate each tags

App/src/libs/IOUUtils.ts

Lines 140 to 148 in 9aa4eed

	function insertTagIntoTransactionTagsString(transactionTags: string, tag: string, tagIndex: number): string {
	const tagArray = TransactionUtils.getTagArrayFromName(transactionTags);
	tagArray[tagIndex] = tag;
	return tagArray
	.map((tagItem) => tagItem.trim())
	.filter((tagItem) => !!tagItem)
	.join(CONST.COLON);
	}

What changes do you think we should make in order to solve the problem?

Dont filter out the empty tag item, change this code to the following

    return tagArray
        .map((tagItem) => tagItem.trim())
        .join(CONST.COLON);

RESULT

-1-New-Expensify.21.mp4

What alternative solutions did you explore? (Optional)

[trjExpensify]

Is this the PR on staging that's the culprit? #46977 CC: @daledah @situchan

I'm not sure what the expected behavior is here, looking to tag the project lead

We shouldn't put values in the wrong level of tag. When it comes to dependent tags, the second dependent level of tag should not be visible unless the first level has been selected. Similarly then, if you remove the first level, we remove the second level.

Pre-condition: Upload dependent tags as admin in old dot

That said. Why do QA keep running multi-tag tests with dependent tags? (CC: @isagoico). AFAIK, we didn't officially build support for them in NewDot. A better test is independent multi-tags, or two levels of coding imported as tags from an accounting solution. CC: @joekaufmanexpensify as displaying tags was built in wave6.

[joekaufmanexpensify]

Agree with using independent tags for tests going forward.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

Tagging in @situchan to review and fix

[FitseTLT]

This regression is causing #47631

[situchan]

@daledah can you please raise PR fixing this and #47631?

[daledah]

I'll raise PR soon

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

Note for myself: No payment required as this was a regression

[daledah]

@situchan PR is ready.

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @grgia, @situchan, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[situchan]

⚠️ We got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production on Aug 30 in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-06] according to Aug 30's production deploy from Deploy Checklist: New Expensify 2024-08-28.

[jliexpensify]

Thanks @situchan - is a checklist needed?

I'll get payment sorted shortly.

[jliexpensify]

Ah wait - was this a regression?

If so, no payment needed?

[situchan]

Oh yes, no payment
We added automated tests to avoid regressions in the future.
We can just close this issue.

[jliexpensify]

Thanks for confirming!