Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-09-06][$250] Navigation - black page when Navigating back from invited workspace chat #47049

Closed
3 of 6 tasks
IuliiaHerets opened this issue Aug 8, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR #45390
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Log in as User A, an account that owns a workspace
  2. Invite B, a user that does not yet have an Expensify account
  3. Check B's email for the invitation
  4. Open the new.expensify.com link from the email in a different browser
  5. Navigate back from the workspace chat (On Web: decrease the window size so you can get the back button)

Expected Result:

Navigating back takes you to LHN

Actual Result:

Navigating back takes you to a black page

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565161_1723109964049.1723083220385_ad8ee684-0ca8-46b9-8c55-76efc6f081bb.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01502c96e8462645b6
  • Upwork Job ID: 1821576366200920163
  • Last Price Increase: 2024-08-15
  • Automatic offers:
    • rayane-djouah | Reviewer | 103586817
    • nkdengineer | Contributor | 103586819
Issue OwnerCurrent Issue Owner: @miljakljajic
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #vip-split

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
@melvin-bot melvin-bot bot changed the title Navigation - black page when Navigating back from invited workspace chat [$250] Navigation - black page when Navigating back from invited workspace chat Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01502c96e8462645b6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@luacmartins
Copy link
Contributor

Invite B, a user that does not yet have an Expensify account

I'm failing on this step, since I get a "404 Account not found" error from the API.

@luacmartins
Copy link
Contributor

Managed to get through by using a gmail email, instead of expensifail. This also happens in prod, so NAB.

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 8, 2024
@nkdengineer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Navigating back takes you to a black page

What is the root cause of that problem?

We handle the exitTo navigation here

Session.handleExitToNavigation(exitTo);
return;

In this function, we use navigate to go to the exitTo so the previous page is still in the stack navigation. Then when we click on the back button, the blank page appears now because the data is loaded

Navigation.navigate(url);

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack to remove the validation page in the navigation stack before we navigate to the exitTo page

Navigation.goBack();
Navigation.navigate(url); 

Session.handleExitToNavigation(exitTo);
return;

What alternative solutions did you explore? (Optional)

Or we can use navigate with type up

Navigation.navigate(url, CONST.NAVIGATION.TYPE.UP); 

Session.handleExitToNavigation(exitTo);
return;

@rayane-djouah
Copy link
Contributor

@nkdengineer Are you still able to reproduce?

@nkdengineer
Copy link
Contributor

nkdengineer commented Aug 12, 2024

@rayane-djouah
Yes, I'm still able to reproduce. The detailed steps:

  1. As user A, invite user B who does not yet have an Expensify account
  2. Login as user B
  3. Check user B's invitation
  4. Open the Expensify URL in the invitation email
  5. Navigate back from the workspace chat (On Web: decrease the window size so you can get the back button)
Screen.Recording.2024-08-12.at.15.28.25.mov

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Aug 13, 2024

@nkdengineer - Unable to reproduce, am I missing anything?

Screen.Recording.2024-08-13.at.7.17.02.PM.mov

@nkdengineer
Copy link
Contributor

@rayane-djouah After inviting user B, you need to login as user B first before opening the invitation URL to reproduce this bug.

Copy link

melvin-bot bot commented Aug 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rayane-djouah
Copy link
Contributor

@nkdengineer - I see, I’m now able to reproduce the issue. Could you please explain why the bug occurs when the user is signed in but not when the user is not signed in?

@nkdengineer
Copy link
Contributor

@rayane-djouah That is because ValidateLoginPage is on both PublicScreen and AuthScreen. If the user is not signed in we run signInWithValidateCode logic in ValidateLoginPage of PublicScreen. After this is successful the user moves to the AuthScreen then ValidateLoginPage isn't in the stack navigator.

@rayane-djouah
Copy link
Contributor

@nkdengineer's proposal looks good to me.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Aug 19, 2024

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Aug 19, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Aug 31, 2024

⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to production deploy from Deploy Checklist: New Expensify 2024-08-28.

cc @miljakljajic

@luacmartins luacmartins changed the title [$250] Navigation - black page when Navigating back from invited workspace chat [HOLD for Payment 2024-09-06][$250] Navigation - black page when Navigating back from invited workspace chat Sep 2, 2024
@luacmartins luacmartins added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Weekly KSv2 labels Sep 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@miljakljajic
Copy link
Contributor

both offers have been accepted and will be paid on the 6th

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 3, 2024
@miljakljajic
Copy link
Contributor

Both contracts paid and ended

@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants