[Hold for payment 2024-09-06] [#wave-control] [Bring copilot to NewDot] Display account switcher

[dangrous]

Part of the Bring copilot to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/382866
Doc section: https://docs.google.com/document/d/18G6J5bl61VnVa5CoKpRXhM0MhkXDwpm87GVitZrSCVg/edit#heading=h.4gw8y2nhd2we
Project: https://github.com/orgs/Expensify/projects/130

Feature Description

Manual Test Steps

Automated Tests

[dangrous]

assigning myself for review once it's ready

[parasharrajat]

Need access to the design doc @dangrous

[rushatgabhane]

Popover bug to fix LATER: #47338 (comment)

IOS: BUG: While offline, Alert does not show up on changing accounts.

[dangrous]

Okay just listing out the additional bugs found so far here. I think we expected there was going to be weirdness, so no worries, but definitely should look into it.

BUGS BEHIND BETA

• Account switcher - App crashes when tapping on the currently active account #48247
• Account switcher - Unable to select account via keyboard #48245
• Avatar - Invalid avatar format error does not disappear after switching account #48252
• Copilot - Not here page opens on central pane when switching account on Subscription tab #48246
• [HOLD for payment 2024-10-24] [$250] When using the account switcher on iOS there is no safe area #48292
• Delegate access: Add account switcher #47338 (comment)

BUGS CURRENTLY VISIBLE

• [Ready for payment] Account switcher - No spacing between account switcher icon and the status icon #48261
• [$250] Avatar - Avatar position moves after error appears (web), incorrect error position (native) #48244
• Profile - Tapping on "Account name", shows interaction, but no redirection #48253
• Profile - Avatar edit modal can be opened while app is loading #48259
• [payment due 9/6][$250] Avatar - Unable to choose profile avatar from library #48242

The second section here is the priority, I think, but they're pretty much all visual quick fixes, nothing too crazy. @rushatgabhane do you think you could fix 'em all in one go?

The ones that are bugs with the copilot feature itself, I think we can probably just include those in the future copilot PRs, rather than doing them separately. Let me know if you disagree.

[rushatgabhane]

@dangrous sounds good

[dangrous]

@parasharrajat assigning you here since you reviewed, will grab a BZ for payment when ready!

[parasharrajat]

Can we please process the C+ payment here? @dangrous Please assign someone.

[dangrous]

oops yep will do!

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

hey @sonialiap! @parasharrajat reviewed this PR as the C+, so will need payment; @rushatgabhane is getting handled at the project level so I believe no payment needed for them right now. We're through the 7 day period also!

[sonialiap]

Thanks Dan :D

[sonialiap]

went to production Aug 30, payment should have been Sep 6 😳

[sonialiap]

Payment summary

• @parasharrajat C+ review - $250 - please request in NewDot
• @rushatgabhane - paid at project level, no payment needed here

[parasharrajat]

Payment requested as per #46920 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat