[HOLD for Payment 2024-08-22][$250] Send invoice - Members are selectable but no option after selecting the members

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to FAB > Send invoice.
3. Enter amount, select participant and send the invoice.
4. In invoice chat, tap on the header.
5. Tap Members.
6. Long press on the invoice participant.
7. Tap Select.

Expected Result:

App should not display option when long pressing on the member in Members page.

Actual Result:

App displays Select option when long pressing on the member in Members page but there is no action available after selecting the member.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6558939_1722496858020.ScreenRecording_08-01-2024_15-14-40_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0189024d7c4bff0b08
• Upwork Job ID: 1819113726462379309
• Last Price Increase: 2024-08-01
• Automatic offers:
• ikevin127 | Contributor | 103414509

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-bills.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - Members are selectable but no option after selecting the members

What is the root cause of that problem?

We allow the member selection to be started for invoice Report Participants. Since these participants cannot be edited, we should not allow the selection to be started.

What changes do you think we should make in order to solve the problem?

We will update the turnOnSelectionModeOnLongPress prop here to account for Invoice Reports

App/src/pages/ReportParticipantsPage.tsx

Line 361 in 3666caa

turnOnSelectionModeOnLongPress={isCurrentUserAdmin}

We will use ReportUtils.isInvoiceReport for the check

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - Members are selectable but no option after selecting the members

What is the root cause of that problem?

turnOnSelectionModeOnLongPress is true even when canSelectMultiple is false.

App/src/pages/ReportParticipantsPage.tsx

Lines 360 to 361 in 3666caa

	canSelectMultiple={canSelectMultiple}
	turnOnSelectionModeOnLongPress={isCurrentUserAdmin}

What changes do you think we should make in order to solve the problem?

Update the turnOnSelectionModeOnLongPress prop to turnOnSelectionModeOnLongPress={isCurrentUserAdmin && canSelectMultiple}. We can also remove isCurrentUserAdmin check because canSelectMultiple already uses that.

We should check other components using SelectionListWithModal with turnOnSelectionModeOnLongPress prop.

What alternative solutions did you explore? (Optional)

We can update the code below:

App/src/components/SelectionListWithModal/index.tsx

Line 45 in 3666caa

if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth) {

To:

        if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth || !rest.canSelectMultiple) {
           return;
       }

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Members are selectable but no option after selecting the members.

What is the root cause of that problem?

We allow changes in the member list only for group chats. But turnOnSelectionModeOnLongPress is using just the isCurrentUserAdmin check.

App/src/pages/ReportParticipantsPage.tsx

Line 361 in 7a0e5a6

turnOnSelectionModeOnLongPress={isCurrentUserAdmin}

What changes do you think we should make in order to solve the problem?

Update the condition to:

turnOnSelectionModeOnLongPress={isGroupChat && isCurrentUserAdmin}

[ShridharGoel]

CC: @pecanoro

#46096

[NikkiWines]

Ah good call out @ShridharGoel - let's see if we end up reverting #46096 and if not we can evaluate proposals to fix this from there

[ikevin127]

@filip-solecki We can probably fix this in a follow-up since we're still within the regression period. Wdyt ?

cc @luacmartins

[ShridharGoel]

I think the original author mentioned somewhere that they're not available as of now, so maybe it can be made external.

[roryabraham]

requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1722544655820829

as discussed in slack, we'll see if this is fixed. but if not, we'll demote it and ship the deploy anyways

[isagoico]

Still able to reproduce the issue on 9.0.15-9 on iOS

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0189024d7c4bff0b08

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays Select option when long pressing on the member in Members page but there is no action available after selecting the member.

What is the root cause of that problem?

The turnOnSelectionModeOnLongPress doesn't match with the check canSelectMultiple. It missed isGroupChat check.

App/src/pages/ReportParticipantsPage.tsx

Line 56 in 5005f59

const canSelectMultiple = isGroupChat && isCurrentUserAdmin && (isSmallScreenWidth ? selectionMode?.isEnabled : true);

App/src/pages/ReportParticipantsPage.tsx

Line 362 in 5005f59

turnOnSelectionModeOnLongPress={isCurrentUserAdmin}

What changes do you think we should make in order to solve the problem?

turnOnSelectionModeOnLongPress and canSelectMultiple have a pattern like this:

canSelectMultiple = canSelectCondition && (isSmallScreenWidth ? selectionMode?.isEnabled : true)
turnOnSelectionModeOnLongPress = canSelectCondition

So we can improve the prop in SelectionListWithModal by replacing turnOnSelectionModeOnLongPress and canSelectMultiple with a prop like canSelect that is canSelectCondition in the pattern above and then we will replace turnOnSelectionModeOnLongPress with canSelect prop

App/src/components/SelectionListWithModal/index.tsx

Line 45 in 5005f59

if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth) {

and pass canSelectMultiple={canSelect && (isSmallScreenWidth ? selectionMode?.isEnabled : true)} here

App/src/components/SelectionListWithModal/index.tsx

Line 69 in 5005f59

<SelectionList

With this change, we can ensure that the selection mode can only be opened if we can select the option and prevent this same bug in the feature.

What alternative solutions did you explore? (Optional)

I think we should move the check group chat into isGroupChatAdmin because this function checks whether a user is an admin of a group chat or not but it doesn't check whether the report is the group chat or not.

App/src/pages/ReportParticipantsPage.tsx

Line 52 in 5005f59

const isCurrentUserAdmin = ReportUtils.isGroupChatAdmin(report, currentUserAccountID);

And then we can remove the check isGroupChat here

App/src/pages/ReportParticipantsPage.tsx

Line 56 in 5005f59

const canSelectMultiple = isGroupChat && isCurrentUserAdmin && (isSmallScreenWidth ? selectionMode?.isEnabled : true);

[github-actions]

true

[filip-solecki]

Hi! I am Filip from SWM and I'd like to take this as it comes from my PR as @ikevin127 mentioned above

[ShridharGoel]

@NikkiWines @roryabraham Am I eligible for compensation here since this was marked as "Help Wanted" and the implemented fix is same as my solution?

[nkdengineer]

@filip-solecki What do you think about my idea in the main solution here? That can prevent the same bug can happening further.

[NikkiWines]

@ShridharGoel yes, in this case you're eligible for compensation (cc: @adelekennedy for when we issue payments)

[mollfpr]

@adelekennedy Please assign @ikevin127, they've reviewed the PR.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

⚠️ Production deploy automation failed here -> this should be on [HOLD for Payment 2024-08-22] according to yesterday’s production deploy confirmed in #46698 (comment) and deploy checklist.

cc @adelekennedy

[ikevin127]

cc @adelekennedy

[adelekennedy]

Payment due date

Payouts due:

• $250 @ShridharGoel link
• $250 @ikevin127

Upwork job is here.

[adelekennedy]

@ShridharGoel bump on accepting the job!

[adelekennedy]

https://expensify.slack.com/archives/C01GTK53T8Q/p1725641031213669