[$250] [HOLD for Payment 2024-09-06][Search v2.1] Include policyID in the Search AST

[luacmartins]

Problem

Currently, we send the policyIDs as a Search API param, however it should be parsed an included in the AST, like we do for other filters.

Solution

Include policyID in the parser grammar and stop sending the policyIDs param

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833303422059505984
• Upwork Job ID: 1833303422059505984
• Last Price Increase: 2024-09-10

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[rayane-djouah]

@luacmartins Is this waiting on backend changes?

[mallenexpensify]

@luacmartins Is this waiting on backend changes?

Same question as @rayane-djouah , I'm unsure of next steps (and commenting to remove Overdue )

[luacmartins]

I think @Kicu might work on this one. Can you confirm?

[Kicu]

yes! I'm working, thanks for pointing out this issue, I missed it

[Kicu]

@luacmartins draft is ready so you might want to take a look. This is surprisingly complex, because I had to make sure all the different cases where we might set policyID from WorkspaceSwitcher are handled.
That is why the changes are spread over multiple files.

Tomorrow I will polish this up and finish the checklist

[luacmartins]

Nice! Thanks for linking the draft. I'll take a look at it today.

[Kicu]

one thing I forgot to mention - I believe now that policyID: xxxx is sent on top level of AST query I think backend is not correctly filtering the results.
Do you mind checking that out @luacmartins ?

[luacmartins]

I saw that last night when working on another PR. Yea, I'll work on this today.

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-6] according to #48221 prod deploy checklist, confirmed in #47787 (comment).

cc @mallenexpensify

[luacmartins]

Not overdue. Payment is due on the 6th

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833303422059505984

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@rayane-djouah can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021833303422059505984

I'm assuming this issue is $250.

[rayane-djouah]

@mallenexpensify I applied to the job

[mallenexpensify]

@rayane-djouah , I think I accidentally sent you an invite without hiring you, which I did just now. Can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021833303422059505984

[rayane-djouah]

@mallenexpensify Accepted, thanks!

[mallenexpensify]

Contributor+: @rayane-djouah paid $250 via Upwork

I'm assuming we don't need a regression test here and that they'll be created as part of the Search project. Thx!