[$250] Accounting – When navigate back from NetSuite page workspace profile page opens

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in with expensifail account
2. Create Workspace> Enable Accounting
3. Go to Accounting
4. Click on connect NetSuite
5. Verify Upgrade modal appears
6. Click Back

Expected Result:

User should land on Accounting page

Actual Result:

User lands on Workspace profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553050_1721937459940.Recording__3588.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01564450f18c93f647
• Upwork Job ID: 1818424433339662150
• Last Price Increase: 2024-07-30
• Automatic offers:
• neonbhai | Contributor | 103358804

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting – When navigate back from NetSuite page workspace profile page opens

What is the root cause of that problem?

We don't define the backTo param here:

App/src/components/ConnectToNetSuiteButton/index.tsx

Line 59 in 6cf5472

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));

What changes do you think we should make in order to solve the problem?

We will add the third param pointing to policyAccountingPage. We will get it from Navigation.getActiveRouteWithoutParams()

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias, Navigation.getActiveRouteWithoutParams()));

Result

Screen.Recording.2024-07-26.at.2.08.11.AM.mov

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting – When navigate back from NetSuite page workspace profile page opens

What is the root cause of that problem?

We are not passing the backTo here

App/src/components/ConnectToNetSuiteButton/index.tsx

Lines 59 to 60 in b0f810d

	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));
	return;

so it will fallback to the workspace profile route here

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 47 to 48 in b0f810d

	onBackButtonPress={() => Navigation.goBack(route.params.backTo ?? ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}
	/>

What changes do you think we should make in order to solve the problem?

We should pass the accounting route as the backTo here

App/src/components/ConnectToNetSuiteButton/index.tsx

Lines 59 to 60 in b0f810d

	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));
	return;

                        Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias, ROUTES.WORKSPACE_ACCOUNTING.getRoute(policyID)));

if needed we can also remove workspace profile fallback route here

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 47 to 48 in b0f810d

	onBackButtonPress={() => Navigation.goBack(route.params.backTo ?? ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}
	/>

What alternative solutions did you explore? (Optional)

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01564450f18c93f647

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[stephanieelliott]

Hey @abdulrahuman5196 we've got a few proposals to review on this one!

[abdulrahuman5196]

Checking now

[abdulrahuman5196]

@neonbhai 's proposal here #46230 (comment) looks good and works well. Other proposals are similar.
The same issue is happening for Sage Intacct connect as well. Kindly fix the same in the PR as well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[robertjchen]

Let's do it 👍

[neonbhai]

Thank you for assigning, raising PR soon!

[stephanieelliott]

Hey @neonbhai looks like the PR review is held on a comment looking from clarification from you -- can you weigh in when you get a sec?

[neonbhai]

hi, I've run in an issue, when testing the upgrade workspace flow that affects navigation:

Steps (Reproducible in prod):

1. Go to collect policy with categories enabled
2. Click on a category -> Click on GL Code
3. Refresh the Page
4. Click back button
5. Modal does not dismiss to chat, we land on workspace profile (bug)
6. Try going to the collect policy and view a category
7. Category Details opens with the workspace list page
8. Click on a Workspace -> click Back
9. User is in a state to view chat without LHN

Screen.20Recording.202024-08-09.20at.209.mp4

We fix this by dismissing the upgrade page when over a chat (instead of falling back to workspace profile). Here:

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 45 to 48 in 87c116b

	<HeaderWithBackButton
	title={translate('common.upgrade')}
	onBackButtonPress={() => Navigation.goBack(route.params.backTo ?? ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}
	/>

onBackButtonPress={() => Navigation.goBack()}

This will make the upgrade page go back only if navigation state has previous items, and to dismiss if user has an empty navigation stack (site reloaded)

Result

This works perfectly:

Screen.Recording.2024-08-09.at.12.39.16.PM.mov

Should we fix this?

👍 - Agree, go ahead
👎 - Disagree

[stephanieelliott]

Hey @robertjchen what do you think of the proposal above?

[robertjchen]

I think we should fix this, please proceed 👍

[stephanieelliott]

Hey @neonbhai checking in from this comment on the PR:

Looks like in #45730 we decided to change navigation connected with upgrade flows, and now redirect to the Token Input pages. This means that the current approach is not needed.

The changes in #45730 also incorporates the solution to related bug noted #46230 (comment), so it's not reproducible

The original issue and reported issue #46230 (comment) are not bugs anymore after the changes.

We should not move forward with current approach. I'll close the PR

With this being the case, are you saying we should close this issue? Also, does that mean that the fix described here is no longer necessary?

[neonbhai]

@stephanieelliott hi, yes the fix in #46230 (comment) was incorporated here in #45730. And since navigation connected to upgrade flow has changed, the approach in this PR is not necessary.

We should close the issue

[neonbhai]

Requesting compensation for the PR 🙇
(same as here)

[melvin-bot]

This issue has not been updated in over 15 days. @robertjchen, @stephanieelliott, @abdulrahuman5196, @neonbhai eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stephanieelliott]

Thanks @neonbhai! Makes sense, I agree we should issue payment for this and then close.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @neonbhai $250 via Upwork -- offer extended, please accept! https://www.upwork.com/nx/wm/offer/103711977
• Contributor+: @abdulrahuman5196 $250 via Upwork -- offer extended, please accept! https://www.upwork.com/nx/wm/offer/103711982

Upwork job is here: https://www.upwork.com/jobs/~01201199f64fde6026

[abdulrahuman5196]

Hi @stephanieelliott I am getting paid via newDot. Will request in newDot.

[robertjchen]

Thanks! 🙇

[JmillsExpensify]

$250 approved for @abdulrahuman5196