Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-03][$250] [Search v2.1] [App] Create Amount filter #46036

Closed
luacmartins opened this issue Jul 23, 2024 · 35 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 23, 2024

Implement this section of the design doc for the Amount filters only!

cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a66609e4336f130d
  • Upwork Job ID: 1816128795512826715
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • rayane-djouah | Contributor | 103317744
Issue OwnerCurrent Issue Owner: @trjExpensify
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 23, 2024
@luacmartins luacmartins self-assigned this Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 23, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@trjExpensify trjExpensify moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 23, 2024
@WojtekBoman
Copy link
Contributor

Hi! I'd like to work on this issue :)

@trjExpensify
Copy link
Contributor

SOLD!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Jul 24, 2024
@melvin-bot melvin-bot bot changed the title [Search v2] [App] Create Amount filter [$250] [Search v2] [App] Create Amount filter Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a66609e4336f130d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 24, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 24, 2024
@WojtekBoman
Copy link
Contributor

@luacmartins What should a page with this filter look like? Amount filter is a range, so we can handle it by having two inputs (from and to) on the page, do you think it will be ok or should we handle it in a different way?

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@luacmartins
Copy link
Contributor Author

luacmartins commented Jul 29, 2024

@Expensify/design do we have any mocks for the amount filter page?

Copy link

melvin-bot bot commented Jul 29, 2024

@trjExpensify, @luacmartins, @WojtekBoman, @ZhenjaHorbach Eep! 4 days overdue now. Issues have feelings too...

@luacmartins
Copy link
Contributor Author

Gonna reassign C+ as per this comment

Copy link

melvin-bot bot commented Aug 8, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 8, 2024

@trjExpensify, @luacmartins, @WojtekBoman, @rayane-djouah 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@trjExpensify
Copy link
Contributor

@WojtekBoman, are you working on this?

@SzymczakJ
Copy link
Contributor

I'll take this from Wojtek after I fix PR comments on #46736, as Wojtek just started a new Expensify project.

@luacmartins luacmartins assigned SzymczakJ and unassigned WojtekBoman Aug 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@SzymczakJ SzymczakJ mentioned this issue Aug 13, 2024
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 14, 2024
@trjExpensify
Copy link
Contributor

PR is on staging.

@rayane-djouah
Copy link
Contributor

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-03] according to #47873 prod deploy checklist, confirmed in #47343 (comment).

cc @trjExpensify

@luacmartins luacmartins changed the title [$250] [Search v2.1] [App] Create Amount filter [HOLD for payment 2024-09-03][$250] [Search v2.1] [App] Create Amount filter Aug 27, 2024
@luacmartins luacmartins added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Weekly KSv2 labels Aug 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
@trjExpensify
Copy link
Contributor

Chill Melv, payment isn't due.

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Overdue Daily KSv2 labels Aug 29, 2024
@luacmartins
Copy link
Contributor Author

Payment is due

@trjExpensify
Copy link
Contributor

Payment summary as follows:

Paid, closing.

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

10 participants