[HOLD for payment 2024-06-21] [$500] mweb - Chat - App crashes when selecting an emoji

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Open emoji picker.
4. Select any emoji.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6430849_1711714841843.Screen_Recording_20240329_201910_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da38a02293ce221e
• Upwork Job ID: 1773831643070943232
• Last Price Increase: 2024-03-29

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[arosiclair]

Reproduced on staging 1.4.58-0. This only happens in with the mobile (isSmallScreenWidth) UI.

[arosiclair]

This seems to be coming from our live markdown code so likely related to #38152. @Skalakid can you take a look at this?

Uncaught DOMException: Failed to execute 'getRangeAt' on 'Selection': 0 is not a valid index.
    at scrollCursorIntoView (webpack-internal:///./node_modules/@expensify/react-native-live-markdown/lib/module/web/cursorUtils.js:136:31)
    at Module.setCursorPosition (webpack-internal:///./node_modules/@expensify/react-native-live-markdown/lib/module/web/cursorUtils.js:94:3)
    at eval (webpack-internal:///./node_modules/@expensify/react-native-live-markdown/lib/module/MarkdownTextInput.web.js:414:51)
    at commitHookEffectListMount (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:23044:26)
    at commitPassiveMountOnFiber (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24811:13)
    at commitPassiveMountEffects_complete (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24776:9)
    at commitPassiveMountEffects_begin (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24763:7)
    at commitPassiveMountEffects (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24751:3)
    at flushPassiveEffectsImpl (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26985:3)
    at flushPassiveEffects (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26930:14)

[ZhenjaHorbach]

Reproduced on staging 1.4.58-0. This only happens in with the mobile (isSmallScreenWidth) UI.

For additional information )
This is also reproduced in desktop Safari

[suneox]

Can I provide a proposal for the issue, not include an External label?

[thienlnam]

Currently being fixed by @Skalakid

[Skalakid]

I created the PR with te fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix app crashing when selecting an emoji #39282

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[arosiclair]

This was just a regression on staging so closing this out without payment.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix app crashing when selecting an emoji #39282

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[situchan]

I wasn't involved in original PR which caused this regression.
So I am still eligible for payment.
cc: @thienlnam

[situchan]

@arosiclair can you please reopen and add Bug label for payment?

[arosiclair]

Makes sense. Adding the Bug label

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

Hey @abekkala can you handle payment for this? Thanks

[abekkala]

@arosiclair is @situchan the only contributor that requires payment? I'm assuming that it's for a PR Review, still at $500? or $250?

[arosiclair]

Yeah only @situchan for his C+ review. I'm not sure why Melvin set the bounty to $500 tbh. I'm pretty sure it should be $250, but it might be worth asking in #bug-zero.

[abekkala]

Ok - I'm sure that it's only $250 - Melvin is just wrong here LOL

[abekkala]

@situchan OFFER has been sent via Upwork.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1773831643070943232/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[situchan]

TL;DR: effective today, Thursday, April 4th, 2024 the initial job price for bugs/feature requests will start at $250.
Any issues created before this date will maintain their original stated price.

The base bounty was changed on Apr 4. The PR was reviewed on Mar 29.

https://expensify.slack.com/archives/C01GTK53T8Q/p1712256409152489

[abekkala]

@situchan updated offer was sent

[abekkala]

@situchan payment sent and contract ended - thank you! 🎉