[HOLD for payment 2024-03-19] [Violations] Implement violations for mutiple tag lists

[cead22]

• When adding support for multiple tags (PR), we broke some violation functionality for single-level tags, and afaict didn't implement them correctly for multi-level tags
• One reason I think we didn't implement them correctly, and this is something I also missed in the original design, is that the Missing $tagLisName (eg, Missing Department) violation, isn't represented with a missingTag violation, but with a someTagLevelsRequired with a data object containing errorIndexes for the tags that are missing. I didn't see any functionality around that in the PR linked above
• I was initially going to add the fix for that in this PR, but once I found about ^ I decided to fix single level tags and update the function signatures I set out to update in that PR, and implement the multi tag violations in a separate PR (which will be linked to this issue)

---

Multi tag file for tests multitags.csv

[melvin-bot]

@cead22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[cead22]

WIP. I'll have a PR up this week

[cead22]

Draft PR is up

[cead22]

PR updated, and should be ready for review early next week

[cead22]

PR submitted for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cead22]

This was done but surfaced another bug #38044, and I found the issue. Let's continue the work there

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add violation logic for multi level tags #37461

If no regressions arise, payment will be issued on 2024-03-19. 🎊

[cead22]

Dependent_tags_tags.csv

[cead22]

popbagel.pdf