[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-10] [Simple AA in NewDot] [HIGH] Improve how we handle auto-submission in NewDot

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tylerkaraszewski
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706118036323349

Action Performed:

Prerequisites:
use a collect policy
has scheduled submit enabled
has access to the isPolicyExpenseChatEnabled beta.

1. Request money from the collect workspace
2. Wait until the report is auto-submitted (i.e end of the day if set to Daily)
3. Observe the Submit button is still present on the report preview for the submitter, despite it being submitted.
4. Observe the submitted $x.xx via Scheduled Submit reportAction is not added to the expense report
5. Sign-in as the approver
6. Observe the workspace chat is not unread for the approver, the LHN does not contain a GBR green dot and the preview component doesn't contain an approve button.

Expected Result:

• On auto-submission, the the submit button should be removed.
• The NewDot reportAction for autoSubmission should be added to the chat from the submitter, the OldDot one from Concierge should not appear in NewDot.
• On auto-submission of the report, the workspace chat should be unread for the approver, the LHN chat row should have a GBR green dot and an approve button should be in the preview component.

Actual Result:

• The submit button is visible and clickable
• The NewDot reportAction is not added to the report, just the OldDot one.
• The approver isn't notified (chat is not unread, no GBR applied, no approve button on the preview)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Screenshots/Videos

Add any screenshot/video evidence

Submit button still visible:
https://github.com/Expensify/App/assets/43996225/f09c69e2-434c-4205-9949-1457cfee28fa

OldDot reportAction appearing not the NewDot one

Chat not unread, no GBR on the chat row in the LHN
To be added

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa9178aa3b2044ea
• Upwork Job ID: 1760318902746746880
• Last Price Increase: 2024-02-21

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

Asking a few Qs: https://expensify.slack.com/archives/C049HHMV9SM/p1706123412357589?thread_ts=1706118036.323349&cid=C049HHMV9SM

[trjExpensify]

Tyler couldn't reproduce this issue. He did run into a different bug with not being able to delete an expense off a processing report, but that's totally different and being figured out over here.

[luacmartins]

I think the issue involves auto-submission. I've noticed that when the report has already been auto-submitted and then I try to submit again. @tylerkaraszewski, do you see any system messages when clicking into the report preview?

[trjExpensify]

Discussion for ref.

[trjExpensify]

Spruced this up in-line with the thread discussion. @mountiny are you taking this one?

[mountiny]

Yes, taking this! Seems like we do send the updates when this comes from harvesting too, will have to dig more

[trjExpensify]

The plot thickens.. Thanks!

[mountiny]

focusing on wave8 critical issue

[mountiny]

still focusing on ideal nav

[mountiny]

Still focusing on the ideal nav over this one, hopefully I can make progress on this one this week

[melvin-bot]

@trjExpensify @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

Still focusing on managing issues in wave8 and fire today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update "automatically approved" report action copy #49909

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1760318902746746880/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

What's the dealio with this project and payments?

[Beamanator]

Pshhhh you don't wanna search through all 168 hidden messages to find linked PRs & who's owed what? 😅

I'll help look tomorrow 😳 🙈

[trjExpensify]

Lol, I more so meant is there 1) some kind of price agreed with the C+ on this for the wider project or is it standard and 2) are regression tests being added centrally for this project.

[trjExpensify]

I'll help look tomorrow 😳 🙈

I'll certainly take it though!

[Beamanator]

Shit well I didn't have time to help today, sry :/ but yeah good question - so far no wider price agreement elsewhere so I thinkkkk it should be paid standard per PR reviewed

[trjExpensify]

Great, so then of the gazillion and one PRs for this issue... narrowing it down to the App PRs only, are any of these additional App PRs considered regressions?

• Update "submitted by harvesting" report action copy #48939
• Update "automatically paid" report action copy #49187
• Support submitted closed report action #49905
• Update "automatically approved" report action copy #49909
• Use setClipboardMessage for html to markdown conversion #50181

[Beamanator]

Personally I wouldn't consider any regressions, I just split up the work into many PRs 😅

[trjExpensify]

Okay, so confirming payments will be as follows:

• Update "submitted by harvesting" report action copy #48939 - $250 to @mollfpr for the C+ review
• Update "automatically paid" report action copy #49187 - no payment due, only Tyler reviewed.
• Support submitted closed report action #49905 - $250 to @mollfpr for the C+ review
• Update "automatically approved" report action copy #49909 - $250 to @mollfpr for the C+ review
• Use setClipboardMessage for html to markdown conversion #50181 - no payment due to Ishpaul, payment is being handled in [HOLD for payment 2024-10-22] Expense - "auto paid with Expensify" system message has <a href="link"> and </a> when pasted #50090

So in total that's $750 to @mollfpr for the C+ reviews here.

With that cleared up, let's talk about the checklist. At the end of the day, what we ended up doing here was an improvement rather than a regression. That being to improve the auto-submit/approver/pay reportActions copy after introducing automation. So I don't think we have a RCA to chase.

We should add/update regression tests for these cases, so @mollfpr can you suggest them for:

• auto-submitted
• auto-approval
• auto-payment

Thanks!

[mollfpr]

auto-submitted

1. Create a policy with delayed submission (example: Daily) & simple or advanced approvals
2. Create a report & a few expenses on that policy
3. Let report auto-harvest
4. Verify the "Submitted" report action now reads automatically submitted via delayed submission where the "Delayed Submission" test links out to https://help.expensify.com/articles/expensify-classic/reports/Automatically-submit-employee-reports

auto-approval

1. Create a collect policy in NewDot
2. In OldDot, set up auto approvals like so:
   • In the workspace Members tab, set "Approval Mode" to "Submit & Approve"
   • In the Manually approve all expenses over the field, enter a number like $200.00 (something over $100)
   • In the Randomly route reports for manual approval: field, enter 0%
3. Set the policy's "scheduled submit" to "on" and to anything other than "Instant" (a.k.a. "Daily")
4. As the submitter, submit an expense for $101.00 (something between $100 and $200)
5. Verify the expense gets auto-approved and the text on LHN and report action is automatically approved $<amount> via workspace rules

auto-approval and auto-forwarding

1. Set up Control policy on NewDot, with Advanced Approvals enabled - non instant submit
2. Make sure the policy has at least 3 members, where at least one employee has an approval chain like this:
   • Employee A submitsTo Employee B
   • Employee B forwardsTo Employee C
3. In OldDot as the policy admin, enable auto approvals
   • In the workspace Members page, set Manually approve all expenses over: to something like $1000
   • Set Randomly route reports for manual approval: to 0%
4. In NewDot, have Employee A submit an expense in their workspace chat
5. Verify the expense is auto approved from Employee B and the text on LHN and report actions is automatically approved $<amount> via workspace rules
6. On Employee C, open the workspace chat for Employee A and verify an expense submitted from Employee A is forwarded to Employee C
7. Approved the expense
8. Verify the text on LHN and report action is approved <amount>

auto-payment

1. Create a Collect policy, on Instant submit, with Submit & Approve enabled
2. In OldDot, in the workspace Members tab, set Manually approve all expenses over: to $0.01
3. In OldDot, in the workspace Reimbursement tab, set reimbursement to Direct and check the Manual Reimbursement section - you should see that Reports above $100.00 are not reimbursed unless manually initiated.
4. Create a withdrawal-ready bank account for the workspace
5. Create a deposit-ready bank account for the workspace owner (personal bank account shouldn't be linked to the workspace
6. In OldDot, as the workspace owner, create a report & add an expense of $1, then approve the report
7. Now open that report in NewDot and verify you see the new "automatically paid" report action copy
8. Now in NewDot, go to the workspace, submit an expense, then approve that report
9. Verify that report also gets auto-reimbursed & shows the new report action copy

[garrettmknight]

$750 approved for @mollfpr based on this summary

[trjExpensify]

@mollfpr I'm not following this test "auto-approval and auto-forwarding"? If auto-approval is enabled in that case, why is the report action approved <amount>?

[mollfpr]

@trjExpensify I believe Employee C can't auto-approve the expense and the report action is expected to approved <amount>. Is that answer your question?

[trjExpensify]

Huh, why not? 🤔 If auto-approval is enabled and the report isn't flagged for review because of the amount and/or random audit percentage, it should be final approved.

[mollfpr]

Maybe @Beamanator can help to answer it 😅

From your above comment, I have the same thought now.

[Beamanator]

Huh, Idk if I wrote that initially but I'd definitely expect that to say "automatically approved ${amount} via <a href="${CONST.CONFIGURE_REIMBURSEMENT_SETTINGS_HELP_URL}">workspace rules</a>,"

Code ref:

App/src/libs/OptionsListUtils.ts

Line 638 in 7b9a0cd

lastMessageTextFromReport = ReportUtils.getReportAutomaticallyApprovedMessage(lastReportAction);

[trjExpensify]

Okay, @mollfpr can we modify the tests then? Do we scrap that second one completely or what else are we including it for?

[mollfpr]

@trjExpensify I have updated step 5 on auto approved and auto forwarding test case. The expected result on "auto approved" is the same as the first auto-approved test case, and the approved <amount> is shown after the forwarder approves the expense.

[trjExpensify]

Sorry, I still don't get it. When auto-approval is enabled, the report is auto-approved at every step in the approval chain, not just the first one. So how is this happening and/or an accurate test?

auto-approval and auto-forwarding

1. Set up Control policy on NewDot, with Advanced Approvals enabled - non instant submit
2. Make sure the policy has at least 3 members, where at least one employee has an approval chain like this:
   • Employee A submitsTo Employee B
   • Employee B forwardsTo Employee C
3. In OldDot as the policy admin, enable auto approvals
   • In the workspace Members page, set Manually approve all expenses over: to something like $1000
   • Set Randomly route reports for manual approval: to 0%
4. In NewDot, have Employee A submit an expense in their workspace chat
5. Verify the expense is auto approved from Employee B and the text on LHN and report actions is automatically approved $<amount> via workspace rules
6. On Employee C, open the workspace chat for Employee A and verify an expense submitted from Employee A is forwarded to Employee C
7. Approved the expense
8. Verify the text on LHN and report action is approved <amount>

[Beamanator]

oh uhhhhh we might not have built multi-auto-approvals yet 🙃 https://github.com/Expensify/Expensify/issues/434467