Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpensiMark: potential problem with parsing links containing mailto: prefix followed by an email #31181

Closed
tomekzaw opened this issue Nov 10, 2023 · 7 comments
Closed

ExpensiMark: potential problem with parsing links containing mailto: prefix followed by an email #31181

tomekzaw opened this issue Nov 10, 2023 · 7 comments
Assignees
@roryabraham @robertKozik
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@tomekzaw
Copy link
Contributor

tomekzaw commented Nov 10, 2023 •
edited
Loading

Required by #27977.

Problem
Currently, ExpensiMark tries to parse emails even if they are located inside another link, for instance in the following case:

 Input: "[[email protected]](mailto:[email protected])"
-Current output: "[<a href=\"mailto:[email protected]\">[email protected]</a>](mailto:<a href=\"mailto:[email protected]\">[email protected]</a>)"
+Desired output: "<a href=\"mailto:[email protected]\">[email protected]</a>"

Solution
Disable parsing Markdown (including emails) in round brackets of a labeled link, i.e. [...](<here>).
@roryabraham roryabraham self-assigned this Nov 10, 2023
@roryabraham roryabraham added Monthly KSv2 Improvement Item broken or needs improvement. Engineering labels Nov 10, 2023
@roryabraham
Copy link
Contributor

Co-assigning myself to supervise, but this will be worked on by Michał Skałka from SWM

@Skalakid
Copy link
Contributor

Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue

@tomekzaw tomekzaw mentioned this issue Nov 14, 2023
Closed
20 tasks
@Skalakid Skalakid mentioned this issue Nov 15, 2023
Merged
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2023
@roryabraham
Copy link
Contributor

It looks like this may have been fixed by Expensify/expensify-common#604. @Skalakid can you please create a follow-up PR to upgrade the version of expensify-common used in E/App so that we can close this issue out?

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2023
@roryabraham
Copy link
Contributor

Posted a thought about potentially reassigning this: https://expensify.slack.com/archives/C04878MDF34/p1703718815187329

@tomekzaw
Copy link
Contributor Author

Should be fixed with Expensify/expensify-common#626

@robertKozik robertKozik mentioned this issue Dec 28, 2023
Merged
@robertKozik
Copy link
Contributor

Can confirm - this issue for live markdown preview use is solved by Expensify/expensify-common#626

@roryabraham roryabraham assigned robertKozik and unassigned Skalakid Dec 28, 2023
@roryabraham roryabraham added the Reviewing Has a PR in review label Dec 28, 2023
@roryabraham roryabraham moved this to In Progress in Live Markdown Dec 28, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 26, 2024

@roryabraham, @robertKozik, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@roryabraham roryabraham moved this from In Progress to Done in Live Markdown Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roryabraham roryabraham

@robertKozik robertKozik

Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
Live Markdown
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomekzaw @Skalakid @roryabraham @robertKozik