Consistent handling of uncached attachments when offline

[thomas-coldwell]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Problem

As mentioned in #13304 (comment), uncached attachments need to be handled more consistently across platforms. Specifically:

• When opening a chat while offline with unloaded images they show as an empty frame:

• When opening the attachment modal (by clicking on an attachment) on native platforms this shows a loading state and on web an empty attachment modal (see screen recording from linked comment above):

Solution

It would probably be best to have some "Unable to load attachment due to connectivity" state shown to the user rather than the blank state documented above. Any loading states for images and other chat attachments should likely have a very generous timeout or just check if offline so the user can be informed the attachment cannot be loaded due to current connectivity issues.

[MelvinBot]

📣 @thomas-coldwell! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[MelvinBot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync